security(promtail): redact secrets from syslog pipeline (#190)#513
Merged
Conversation
Apply the same five replace stages used by the hermes and nats scrape jobs
(bearer, token=, key=, secret=, password=) to the syslog job. Host-level
syslog may contain credentials if system services log them, so the same
redaction guarantees must hold.
Adds tests/test_configs.py::test_redaction_enabled_jobs_have_secret_patterns,
which iterates over the set {syslog, hermes, nats} and asserts each carries
all five patterns — preventing future regressions where a new redaction-
enabled job ships without the required stages.
Closes #190
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #190.
replacepipeline stages used by thehermesandnatsscrape jobs to thesyslogjob inconfigs/promtail.yml:bearer <token>token=<value>key=<value>secret=<value>password=<value>TestPromtailConfig.test_redaction_enabled_jobs_have_secret_patterns, iterating over{syslog, hermes, nats}and asserting each job carries all five required redaction expressions. Prevents future regressions where a redaction-enabled job ships without the standard stages.Scope
Test plan
pytest tests/test_configs.py::TestPromtailConfig -v— 12/12 pass locally (coverage gate is unrelated to config tests).