Skip to content

test(ci): run server/ + shared/ vitest suites in the merge gate #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HomenShum wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(ci): run server/ + shared/ vitest suites in the merge gate #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,18 @@ jobs:
- name: Runtime smoke tests
run: >
npx vitest run
server/lib/jsonObjectParser.test.ts
server/agentHarnessStructuredOutput.test.ts
src/features/product/lib/captureRouter.test.ts
src/features/workspace/lib/eventWorkspacePersistence.test.ts
src/features/workspace/data/eventWorkspaceMemory.test.ts
convex/__tests__/scratchnode.events.test.ts
server/searchRoute.test.ts

# Full server/ + shared/ vitest suites. These dirs sit outside src/ and
# packages/, so they were previously neither run by the segmented runner
# nor by the smoke list above — only type-checked. Tests there (e.g. the
# tri-search rerank suite) could rot silently. Running the segments here
# puts them in the required merge gate.
- name: Server + shared vitest segments
run: node scripts/testing/runSegmentedVitest.mjs --only server,shared
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 29, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At .github/workflows/ci.yml:93, this invokes runSegmentedVitest.mjs, but runShell() in that script starts a timeout that isn’t cleared when the child process exits; if the server,shared suites finish in <300s, the step can remain alive until the timer fires. That would add a fixed ~5 minute delay to the required merge gate even when tests complete quickly.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.


scratchnode-launch-gates:
name: ScratchNode launch gates
Expand Down
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
"preflight:production": "node scripts/preflight-deploy.mjs --target=production",
"preflight:fast": "node scripts/preflight-deploy.mjs --skip=tsc-convex,search-api,size",
"preflight:json": "node scripts/preflight-deploy.mjs --json",
"repo:export:scratchnode-live": "node scripts/repo/export-scratchnode-live-public.mjs --out .tmp/scratchnode-live-public-export",
"repo:export:scratchnode-live:force": "node scripts/repo/export-scratchnode-live-public.mjs --out .tmp/scratchnode-live-public-export --force",
"post-deploy:verify": "node scripts/post-deploy-verify.mjs",
"post-deploy:verify:fast": "node scripts/post-deploy-verify.mjs --skip=live-smoke",
"post-deploy:verify:json": "node scripts/post-deploy-verify.mjs --json",
Expand All @@ -35,6 +37,8 @@
"test:run:full": "node scripts/testing/runSegmentedVitest.mjs --include-overstory true",
"test:run:vitest": "vitest run",
"test:run:app": "node scripts/testing/runVitestSegment.mjs --cwd . --target src --mode dir",
"test:run:server": "node scripts/testing/runVitestSegment.mjs --cwd . --target server/ --mode filter",
"test:run:shared": "node scripts/testing/runVitestSegment.mjs --cwd . --target shared/ --mode filter",
"test:run:mcp-local": "npm --prefix packages/mcp-local test",
"test:run:convex-mcp": "node scripts/testing/runVitestSegment.mjs --cwd packages/convex-mcp-nodebench --target src --mode filter",
"test:run:openclaw-mcp": "node scripts/testing/runVitestSegment.mjs --cwd packages/openclaw-mcp-nodebench --target src --mode filter",
Expand Down
14 changes: 14 additions & 0 deletions scripts/testing/runSegmentedVitest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,20 @@ async function main() {
timeoutMs: 300_000,
required: true,
},
{
id: "server",
label: "server-vitest",
command: "npm run test:run:server",
timeoutMs: 300_000,
required: true,
},
{
id: "shared",
label: "shared-vitest",
command: "npm run test:run:shared",
timeoutMs: 300_000,
required: true,
},
{
id: "mcp-local",
label: "mcp-local-vitest",
Expand Down
Loading
Loading