libgraphqlparser: deprecate as it requires Python 2#83290
libgraphqlparser: deprecate as it requires Python 2#83290cho-m wants to merge 1 commit intoHomebrew:masterfrom
Conversation
cho-m
added
in progress
There was a problem hiding this comment.
Not a huge fan of this (but not a very strong opinion).
I actually think we should consider deprecating formulae that still need Python2. Thoughts, @Homebrew/core?
There was a problem hiding this comment.
I'm open to opinions here as I'm mainly experimenting with this.
In terms of Python2 formulae, the most popular ones didn't work on quick attempt, i.e.
node@10- failed with generic message. It is already deprecated, but is remains popular (at least on macOS = 5.5k+ installs/mo). It is also a dependency forkibana(deprecated)/opensearch-dashboards(should update to newer node that builds with Python3).bazaar- it builds, but has Python runtime dependency, with some code that is designed around CPython. It is a dependency forinfluxdb, which is reasonably popular (macOS = 2.4k+ installs/mo)
There was a problem hiding this comment.
I believe @iMichka and @sjackman have a expressed a strong opposition to supporting Python 2 in any way on Linux, and I completely agree with them on this. I would support deprecating all formulae which still depend on Python 2 as well, unless the upstream team has provided a clear roadmap for when they will transition to Python 3. We are coming up on 2 years since Python 2 EOL, and I think it is unacceptable for projects to depend on an unsupported language like this.
Specifically regarding bazaar, Fedora has replaced it with breezy, a maintained forked that should be drop in compatible: https://fedoraproject.org/wiki/Changes/ReplaceBazaarWithBreezy. We could disable the bazaar formula and make bzr an alias to breezy.
For this particular formula, I think it should be deprecated and we should notify upstream that this has happened. There has a been a pull request open for 3 years to add Python 3 support: graphql/libgraphqlparser#66. It was also noted in the issue that this repo may no longer have an active maintainer: graphql/libgraphqlparser#66.
There was a problem hiding this comment.
Yeah, let's not add back python 2 support. So much work has been done to get rid of it.
There was a problem hiding this comment.
Agreed with deprecating these formulae.
cho-m
force-pushed
the
libgraphqlparser-linux
branch
from
73e7895 to
3344a5b
Compare
cho-m
changed the title
BrewTestBot
added
formula deprecated
| sha256 cellar: :any, high_sierra: "64779ec3108d9eef789d279abfafa90437c6a76b2ed3973d45979cd1051dc170" | ||
| end | ||
|
|
||
| deprecate! date: "2020-04-20", because: "requires Python 2 to build" |
There was a problem hiding this comment.
Some dates I was considering:
2020-04-20was final Python 2 (2.7.18) release date.2020-01-01was official Python 2 EOL date.
Could also just use current date or 2021-04-20 as 1+ year after final release.
There was a problem hiding this comment.
Let's just go with today, so that it's easier for us to figure out if enough time has passed to disable! it.
cho-m
removed
in progress
cho-m
added
CI-syntax-only
|
🤖 A scheduled task has triggered a merge. |
6 participants
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Experimenting with
pypyfor some Python 2-dependent formulae.Seemed to build locally.