Skip to content

lastpass-cli : add workaround for openssl 3.5 API change#254855

Merged
BrewTestBot merged 2 commits intoHomebrew:mainfrom
TheMysteriousX:patch-1
Nov 18, 2025
Merged

lastpass-cli : add workaround for openssl 3.5 API change#254855
BrewTestBot merged 2 commits intoHomebrew:mainfrom
TheMysteriousX:patch-1

Conversation

@TheMysteriousX
Copy link
Copy Markdown
Contributor

This pulls in a PR from the lastpass-cli repository that primarily fixes the ability to write notes.

Without it, the cli tool breaks frequently with an error about being unable to base64 decode the response - this is because lastpass-cli without the change blindly passes all input from the attachment_key field to OpenSSL.

Older versions of OpenSSL silently dealt with this, newer ones don't so the patch referenced is a 1 line change to make sure that if the string that would be passed to OpenSSL is "skipped", the string is not passed to OpenSSL so the same code path is followed under all versions.

I am not the author of the patch - I'm a user of the CLI tool, and have been using a source version of the tool with the patch for around 3 months on both Sequoia and Tahoe with no issues.

This is a re-submit of #254800 as I'm not able to re-open it with the truncated line fixed.
I've bumped the revision as suggested and used the re-formatted title, however I'm not sure what is meant by 'please make sure you are a human'.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This pulls in a PR from the lastpass-cli repository that primarily fixes the ability to write notes.

Without it, the cli tool breaks frequently with an error about being unable to base64 decode the response - this is because lastpass-cli without the change blindly passes all input from the attachment_key field to OpenSSL.

Older versions of OpenSSL silently dealt with this, newer ones don't so the patch referenced is a 1 line change to make sure that if the string that would be passed to OpenSSL is "skipped", the string is not passed to OpenSSL so the same code path is followed under all versions.
@chenrui333
Copy link
Copy Markdown
Member

@chenrui333
Copy link
Copy Markdown
Member

@TheMysteriousX thanks for backporting this fix, and sorry for closing your other PR.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions Bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 18, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 18, 2025
Merged via the queue into Homebrew:main with commit 06bb104 Nov 18, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants