lastpass-cli : add workaround for openssl 3.5 API change#254855
Merged
BrewTestBot merged 2 commits intoHomebrew:mainfrom Nov 18, 2025
Merged
lastpass-cli : add workaround for openssl 3.5 API change#254855BrewTestBot merged 2 commits intoHomebrew:mainfrom
BrewTestBot merged 2 commits intoHomebrew:mainfrom
Conversation
This pulls in a PR from the lastpass-cli repository that primarily fixes the ability to write notes. Without it, the cli tool breaks frequently with an error about being unable to base64 decode the response - this is because lastpass-cli without the change blindly passes all input from the attachment_key field to OpenSSL. Older versions of OpenSSL silently dealt with this, newer ones don't so the patch referenced is a 1 line change to make sure that if the string that would be passed to OpenSSL is "skipped", the string is not passed to OpenSSL so the same code path is followed under all versions.
chenrui333
approved these changes
Nov 18, 2025
Member
|
@TheMysteriousX thanks for backporting this fix, and sorry for closing your other PR. |
Contributor
|
🤖 An automated task has requested bottles to be published to this PR. Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in a PR from the lastpass-cli repository that primarily fixes the ability to write notes.
Without it, the cli tool breaks frequently with an error about being unable to base64 decode the response - this is because lastpass-cli without the change blindly passes all input from the attachment_key field to OpenSSL.
Older versions of OpenSSL silently dealt with this, newer ones don't so the patch referenced is a 1 line change to make sure that if the string that would be passed to OpenSSL is "skipped", the string is not passed to OpenSSL so the same code path is followed under all versions.
I am not the author of the patch - I'm a user of the CLI tool, and have been using a source version of the tool with the patch for around 3 months on both Sequoia and Tahoe with no issues.
This is a re-submit of #254800 as I'm not able to re-open it with the truncated line fixed.
I've bumped the revision as suggested and used the re-formatted title, however I'm not sure what is meant by 'please make sure you are a human'.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?