Skip to content

Исправил код#45

Open
Taurus85910 wants to merge 4 commits into
HolyMonkey:masterfrom
Taurus85910:master
Open

Исправил код#45
Taurus85910 wants to merge 4 commits into
HolyMonkey:masterfrom
Taurus85910:master

Conversation

@Taurus85910
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@HolyMonkey HolyMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не вижу реализация EnemiesList

Comment thread Assets/Group1/Scripts/EnemyMovement.cs Outdated

private void Start()
{
_targetPosition = Random.insideUnitCircle * _radiusModifier;
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дублирует код на 20ой строке

Comment thread Assets/Group1/Scripts/EnemyMovement.cs Outdated
SetTargetPosition();
}

private void SetTargetPosition()
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почитай про CQRS, метод Set - это метод который устанавливает состояние из параметра. У тебя тут должен быть другой глагол

Comment thread Assets/Group1/Scripts/EnemyMovement.cs Outdated
{
[SerializeField] private int _radiusModifier;
[SerializeField] private int _speed;
private Vector3 _targetPosition;
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Просто target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants