Refactor#31
Open
VKladov wants to merge 3 commits into
Open
Conversation
HolyMonkey
requested changes
Feb 17, 2021
|
|
||
| public class MoveIncideCircle : MonoBehaviour | ||
| { | ||
| [SerializeField] private float _maxDistance = 4; |
| using System.Collections.Generic; | ||
| using UnityEngine; | ||
|
|
||
| public class MoveIncideCircle : MonoBehaviour |
| [SerializeField] private float _maxDistance = 4; | ||
| [SerializeField] private float _speed = 2; | ||
|
|
||
| private Vector3 _targetPosition; |
Comment on lines
+31
to
+45
| private IEnumerator ResetSpeed(float delay) | ||
| { | ||
| yield return new WaitForSeconds(delay); | ||
| _speed = _defaultSpeed; | ||
| _boostResetCoroutine = null; | ||
| } | ||
|
|
||
| private void BoostSpeed(float multiplier, float duration) | ||
| { | ||
| if (_boostResetCoroutine != null) | ||
| StopCoroutine(_boostResetCoroutine); | ||
|
|
||
| _speed = _defaultSpeed * multiplier; | ||
| _boostResetCoroutine = StartCoroutine(ResetSpeed(duration)); | ||
| } |
Owner
There was a problem hiding this comment.
Перемудрил. Это всё в 3 строки можно записать
| using System.Collections.Generic; | ||
| using UnityEngine; | ||
|
|
||
| public class SpeedBoost : MoveIncideCircle |
Comment on lines
+40
to
+41
| if (_boostResetCoroutine != null) | ||
| StopCoroutine(_boostResetCoroutine); |
Owner
There was a problem hiding this comment.
Не надо предыдущий бустер завершать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done!