MyFirstRefactoring#27
Open
flangedmace wants to merge 18 commits into
Open
Conversation
HolyMonkey
requested changes
Jan 21, 2021
|
|
||
| [RequireComponent(typeof(Rigidbody2D))] | ||
| [RequireComponent(typeof(CircleCollider2D))] | ||
| public abstract class Follower : MonoBehaviour |
| [SerializeField] private Rigidbody _rigidbody; | ||
|
|
||
| [SerializeField] private float _moveSpeed; | ||
| [SerializeField] private float _maxTargetDistance; |
|
|
||
| protected virtual void OnTriggerEnter2D(Collider2D collision) { } | ||
|
|
||
| private void SetTargetPosition() |
|
|
||
| private void Start() | ||
| { | ||
| _startEnemies = GameObject.FindGameObjectsWithTag("Enemy").Length; |
Owner
There was a problem hiding this comment.
Мы не используем FindGameObjectsWithTag
| } | ||
| } | ||
|
|
||
| public IEnumerator BoostSpeed(float workingTime) |
| { | ||
| if (collision.gameObject.TryGetComponent<Player>(out Player player)) | ||
| { | ||
| StartCoroutine(player.BoostSpeed(player.BoostSpeedTime)); |
Owner
There was a problem hiding this comment.
Я думаю лучше отсюда передавать и время и силу ускорения
HolyMonkey
requested changes
Feb 17, 2021
| { | ||
| if (collision.gameObject.TryGetComponent<Enemy>(out Enemy enemy)) | ||
| { | ||
| GetComponentInParent<LevelFinisher>().AddKilledEnemy(); |
| _rigidbody.velocity = (_target - transform.position).normalized * _speed * Time.deltaTime; | ||
|
|
||
| if (transform.position == _target) | ||
| _target = Random.insideUnitCircle * _radius; |
|
|
||
| private void Update() | ||
| { | ||
| _rigidbody.velocity = (_target - transform.position).normalized * _speed * Time.deltaTime; |
Owner
There was a problem hiding this comment.
Есть замечательная функция которая работает точней.
У тебя как минимум противник будет регулярно пролетать сквозь цель
| _maxEnemiesNumber = GetComponentsInChildren<Enemy>().Length; | ||
| } | ||
|
|
||
| public void AddKilledEnemy() |
Owner
There was a problem hiding this comment.
Небезопасный метод. Нужно ориентироваться по мёртвым противникам. Сейчас у тебя счётчик живёт отдельно и никак не согласован
|
|
||
| private void Update() | ||
| { | ||
| _rigidbody.velocity = new Vector2(Input.GetAxis("Horizontal"), Input.GetAxis("Vertical")) * _moveSpeed * Time.deltaTime; |
| _rigidbody.velocity = new Vector2(Input.GetAxis("Horizontal"), Input.GetAxis("Vertical")) * _moveSpeed * Time.deltaTime; | ||
| } | ||
|
|
||
| public IEnumerator BoostSpeed(float duration, float multiplier) |
Owner
There was a problem hiding this comment.
А вот это охуительно сделано. Молодец!
HolyMonkey
requested changes
Feb 25, 2021
Comment on lines
+29
to
+38
| public void AddKilledEnemy(Enemy enemy) | ||
| { | ||
| _deadEnemies.Add(enemy); | ||
|
|
||
| if (_deadEnemies.Count >= _maxEnemiesNumber) | ||
| { | ||
| _menu.SetActive(true); | ||
| gameObject.SetActive(false); | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
_aliveEnemies убираешь из него противника и смотришь осталось ли там что-то
HolyMonkey
requested changes
Mar 4, 2021
| { | ||
| public event OnDied Died; | ||
|
|
||
| public delegate void OnDied(Enemy sender); |
Owner
There was a problem hiding this comment.
Делегаты мы сами не определяем, а если бы и определяли то стиль там не такой. Воспользуйся стандартными Action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.