-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: detect engine task death mid-turn and recover UI immediately #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gordonlu
wants to merge
5
commits into
Hmbown:main
Choose a base branch
from
gordonlu:feat/engine-death-recovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
69160ce
fix: detect engine task death mid-turn and recover UI immediately
gordonlu 5fc674e
fix: address PR review - add needs_redraw, fix import order, expand d…
moondust2024 17ab0d2
fix: use rx.is_closed() instead of try_recv() probe to avoid race con…
moondust2024 49e5239
fix: align test with production logic, fix fmt
gordonlu 50c452d
fix: remove unused mut on rx in test
gordonlu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
TurnCompletehandler has an explicit "hard-fail recovery" path that callsapp.drain_pending_steers()and requeues those messages so they are not silently lost (see theTurnOutcomeStatus::Failedbranch). This disconnect recovery block is intended to substitute for that path when the engine dies without ever emittingTurnComplete, but it never drainsapp.pending_steers. Any steer messages the user composed mid-turn and held with Esc will be silently discarded rather than surfaced in the queue where the user can see and re-send them.