Skip to content

feat(tui): add mention browser completions#2551

Closed
cyq1017 wants to merge 2 commits into
Hmbown:mainfrom
cyq1017:codex/2368-mention-browser-mode
Closed

feat(tui): add mention browser completions#2551
cyq1017 wants to merge 2 commits into
Hmbown:mainfrom
cyq1017:codex/2368-mention-browser-mode

Conversation

@cyq1017
Copy link
Copy Markdown
Contributor

@cyq1017 cyq1017 commented Jun 1, 2026

Summary:

  • add an opt-in mention_menu_behavior = "browser" mode for @-mention completions
  • list only immediate children for the typed directory segment, sorted deterministically
  • keep the default fuzzy/frecency completion behavior unchanged

Validation:

  • cargo fmt --all -- --check
  • cargo check -p codewhale-tui --all-features --locked
  • cargo test -p codewhale-tui --all-features --locked browser_completions
  • cargo test -p codewhale-tui --all-features --locked mention_popup_browser_mode_lists_immediate_directory_children
  • cargo test -p codewhale-tui --all-features --locked mention_completion_caps_are_configurable
  • cargo test -p codewhale-tui --all-features --locked file_mention
  • git diff --check

Refs #2368

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cyq1017 has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cyq1017 has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@Hmbown
Copy link
Copy Markdown
Owner

Hmbown commented Jun 2, 2026

Thanks @cyq1017, this is a useful opt-in UX improvement for deep workspaces. I harvested it into #2504 as 73cd72166 and f185d4691 after upstream CI was green.

I also added a small local containment hardening while resolving the release-branch conflict: browser mode now rejects parent/root/prefix path components in the directory segment, with browser_completions_reject_path_escape_segments covering the @../ case.

Local verification on the release branch:

  • for filter in browser_completions mention_popup_browser_mode_lists_immediate_directory_children mention_completion_caps_are_configurable file_mention; do cargo test -p codewhale-tui --all-features --locked "$filter" -- --nocapture || exit 1; done
  • cargo check -p codewhale-tui --all-features --locked
  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/release/check-versions.sh
  • cargo clippy -p codewhale-tui --all-targets --all-features --locked -- -D warnings

@Hmbown
Copy link
Copy Markdown
Owner

Hmbown commented Jun 3, 2026

This PR was harvested into v0.8.50. Closing as already landed.

@Hmbown Hmbown closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants