Skip to content

🧹 [code health improvement] Avoid using any type and eslint-disable comments in ThemeController.test.tsx #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
is0692vs wants to merge 1 commit into from
Closed

🧹 [code health improvement] Avoid using any type and eslint-disable comments in ThemeController.test.tsx #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/components/__tests__/ThemeController.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ const { mockGetColorAsync, mockDestroy } = vi.hoisted(() => ({
// The hook uses fast-average-color, which we need to mock so it doesn't try to fetch real images in tests.
vi.mock("fast-average-color", () => {
return {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
FastAverageColor: vi.fn().mockImplementation(function(this: any) {
FastAverageColor: vi.fn().mockImplementation(function(this: { getColorAsync: unknown; destroy: unknown }) {
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When mocking FastAverageColor, ensure that the test suite includes cases for failure scenarios, such as a rejected promise from getColorAsync. This is necessary to verify that the application's error handling logic functions correctly and that fallback colors are maintained, as per repository rules for asynchronous color operations.

References
  1. Ensure that asynchronous operations (e.g., color extraction from images) have test cases covering failure scenarios (e.g., rejected promises) to verify that error handling logic works correctly and fallback values are preserved.

this.getColorAsync = mockGetColorAsync;
this.destroy = mockDestroy;
return this;
Expand Down Expand Up @@ -44,8 +43,7 @@ describe("ThemeController", () => {
value: [100, 150, 200, 255]
});
// Ensure adjustAccentColor mock implementation is restored
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(colorLib.adjustAccentColor as any).mockImplementation((color: any) => ({
vi.mocked(colorLib.adjustAccentColor).mockImplementation((color) => ({
accent: `mock-accent-${color}`,
accentRgb: `mock-rgb-${color}`,
accentHover: `mock-hover-${color}`,
Expand Down
Loading