Skip to content

🧹 [code health improvement] Remove any type and eslint-disable comment in useThemeColor.test.ts #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
is0692vs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧹 [code health improvement] Remove any type and eslint-disable comment in useThemeColor.test.ts #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/hooks/__tests__/useThemeColor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,15 @@ import * as colorLib from "@/lib/color";
import { FastAverageColor } from "fast-average-color";

// Mock fast-average-color
interface MockFastAverageColor {
getColorAsync: ReturnType<typeof vi.fn>;
destroy: ReturnType<typeof vi.fn>;
}
vi.mock("fast-average-color", () => {
const mockGetColorAsync = vi.fn();
const mockDestroy = vi.fn();
return {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
FastAverageColor: vi.fn().mockImplementation(function(this: any) {
FastAverageColor: vi.fn().mockImplementation(function(this: MockFastAverageColor) {
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In TypeScript, ensure functions and mock implementations have explicit return types to maintain type safety and readability. Adding the return type to the mock implementation function ensures consistency and better type checking.

Suggested change
FastAverageColor: vi.fn().mockImplementation(function(this: MockFastAverageColor) {
FastAverageColor: vi.fn().mockImplementation(function(this: MockFastAverageColor): MockFastAverageColor {
References
  1. In TypeScript, ensure functions and mock implementations have explicit return types and use async functions for mocks returning Promises to maintain type safety and readability.
  2. Maintain explicit return types for functions in TypeScript to ensure type safety and API clarity.

this.getColorAsync = mockGetColorAsync;
this.destroy = mockDestroy;
return this;
Expand Down
Loading