Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes incorrect usage of #pragma once from C++ implementation files (.cpp). The #pragma once directive is a header guard that should only be used in header files (.h) to prevent multiple inclusion, not in implementation files.
Changes:
- Removed
#pragma oncefrom three .cpp files where it was incorrectly placed - Reformatted LinuxPlatformUtils.cpp to use consistent whitespace (spaces instead of tabs)
- Reordered includes in LinuxPlatformUtils.cpp to maintain consistency
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Engine/src/Platform/Windows/WindowsPlatformUtils.cpp | Removed incorrect #pragma once directive |
| Engine/src/Himii/Renderer/Renderer2D.cpp | Removed incorrect #pragma once directive |
| Engine/src/Himii/Renderer/Buffer.cpp | Removed incorrect #pragma once directive |
| Engine/src/Platform/Linux/LinuxPlatformUtils.cpp | Reformatted with consistent spacing and brace placement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
我也不知道为什么编辑器把\t 换成空格了