Subsystem/comp turret #33
Open
+225
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SCool62
requested changes
Feb 1, 2026
Contributor
SCool62
left a comment
SCool62
left a comment
There was a problem hiding this comment.
Looks very good, but you still need to write a TurretIOSim.
| public static double HOOD_GEAR_RATIO = 24.230769; | ||
| public static Rotation2d HOOD_MAX_ROTATION = Rotation2d.fromDegrees(40); | ||
| public static Rotation2d HOOD_MIN_ROTATION = Rotation2d.fromDegrees(2); | ||
| public static double TURRET_GEAR_RATIO = (12.0 / 42.0) * (16.0 / 32.0) * (10.0 / 85.0); |
Contributor
There was a problem hiding this comment.
I assume you've checked this with cad?
| /** Add your docs here. */ | ||
| public class TurretIO { | ||
| @AutoLog | ||
| public static class TurretIOInputs { |
| public double turretSupplyCurrentAmps = 0.0; | ||
| public double turretVoltage = 0.0; | ||
| public double turretTempC = 0.0; | ||
| // _TODO: Input reall values |
| private VelocityVoltage velocityVoltage = new VelocityVoltage(0.0).withEnableFOC(true); | ||
|
|
||
| public TurretIO(TalonFXConfiguration talonFXConfiguration, CANBus canbus) { | ||
| turretMotor = new TalonFX(11, canbus); |
Contributor
There was a problem hiding this comment.
The shooter hood is already ID 11. Comp CAN ids haven't been decided yet so for now give it a large random number (like 40 or smth) for now
Contributor
There was a problem hiding this comment.
Btw this is so that the ids don't clash during sim
Contributor
There was a problem hiding this comment.
Ig its not on this branch so maybe it doesn't matter but better avoid the problem now then fix it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.