Add: logging system for debugging and audit trail#26
Merged
HiddenKeyDev merged 2 commits intoHiddenKeyDev:mainfrom Oct 6, 2025
Merged
Add: logging system for debugging and audit trail#26HiddenKeyDev merged 2 commits intoHiddenKeyDev:mainfrom
HiddenKeyDev merged 2 commits intoHiddenKeyDev:mainfrom
Conversation
Implements comprehensive logging functionality (HiddenKeyDev#3): - Add log_message() function with timestamp formatting - Implement log rotation when file exceeds 1MB - Add ENABLE_LOGGING and LOG_PRIVACY config options - Create 'log' command with --tail and --clear options - Add logging to create, start, and stop operations - Include privacy mode to avoid logging sensitive data - Update README with logging documentation All acceptance criteria met: - Logging can be enabled/disabled via config - Log file created in ~/.config/nm-hotspot/ - All major actions are logged with timestamps - Log viewing and clearing commands implemented - Log rotation functionality included - Privacy-conscious with LOG_PRIVACY option
There was a problem hiding this comment.
Thanks for opening your first pull request in nm-hotspot-cli, @AdityaDwiNugroho.
A maintainer will review your contribution. Here's what happens next:
- Automated checks will run
- A maintainer will review your code
- Changes may be requested
- Once approved, your PR will be merged
Please ensure:
- Your code follows the project style guidelines
- You have tested your changes
- Documentation is updated if needed
Thank you for contributing.
Owner
|
Thanks for the contribution! Could you please address the ShellCheck errors before we proceed with the review? |
Add 'true' command before redirection to comply with ShellCheck best practices. This fixes the warning about redirection without a command in the log clearing functionality.
Owner
|
LGTM! Great work on implementing the logging system. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements comprehensive logging functionality (#3):
All acceptance criteria met: