fix: resolve PolyBool T-Junction crash in BayazitDecomposer#37
Open
bomlinux92-byte wants to merge 1 commit into
Open
fix: resolve PolyBool T-Junction crash in BayazitDecomposer#37bomlinux92-byte wants to merge 1 commit into
bomlinux92-byte wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for [BOUNTY $50] PolyBool can cause an editor crash on T-Junctions — Issue #17
Root cause
Boolean operations using PolyBool mistakenly merge two shapes at a T-junction singularity (where one shape's vertex touches another shape's edge at a non-endpoint position). This creates an invalid polygon that causes the BayazitDecomposer to fail with a stack overflow when trying to perform convex decomposition.
Fix
Added T-junction singularity detection and splitting to BayazitDecomposer.cs:
TrySplitAtSingularity()- entry point that detects and splits at singularities before decompositionTrySplitAtCoincidentVertex()- detects when two non-adjacent vertices occupy the same positionTrySplitAtVertexOnEdge()- detects when a vertex lies on an edge (T-junction) and splits the edgePrepareSplitPolygon()- validates and prepares split resultsThe fix proactively splits polygons at T-junctions before PolyBool operations, preventing the invalid merged state that causes the crash.
Testing
The fix handles the specific case from the issue where two B-shaped polygons were incorrectly merged at an infinitely thin connection point.
Closes #17