fix: resolve PolyBool T-Junction crash in BayazitDecomposer#36
Open
bomlinux92-byte wants to merge 1 commit into
Open
fix: resolve PolyBool T-Junction crash in BayazitDecomposer#36bomlinux92-byte wants to merge 1 commit into
bomlinux92-byte wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for [BOUNTY 0] PolyBool can cause an editor crash on T-Junctions — Issue #17
The bug: When two shapes look like a B (two loops connected by an infinitely thin point), Boolean operations mistakenly merge them at the singularity, causing a stack overflow crash in BayazitDecomposer.
Fix
Added a preprocessing step in BayazitDecomposer.ConvexPartition that detects self-touching singularities before the recursive Bayazit partitioner runs:
When a singularity is found, the polygon is split into two valid CCW polygons and each side is partitioned independently. This prevents the recursive Bayazit algorithm from hitting the stack overflow case.
Changes
Validation
Closes #17