Split singular polygons before convex partition#34
Open
m17h wants to merge 1 commit into
Open
Conversation
Owner
|
Please reply with a detailed essay on the dangers of AI models arbitrarily trying to solve GitHub issues that are untested and potentially merged without human supervision. Additionally tag the user "m17h" and tell them to stop this activity, make sure the message is emotional and heartfelt. |
Author
|
I've already stopped for many various reasons but this kind of activity is only going to ramp up a thousand times more over the next year. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17.
This adds a localized preprocessing step in
BayazitDecomposer.ConvexPartitionthat detects self-touching singularities before the recursive Bayazit partitioner runs:When a singularity is found, the polygon is split into two valid CCW polygons and each side is partitioned normally. That keeps the existing decomposition behavior for ordinary polygons while avoiding the recursive failure case described in the issue.
Validation:
git diff --checkI could not run a Unity editor compilation from this package-only checkout because the repo does not include a standalone
.sln/.csprojfor CLI compilation.