Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR contains several small bugfixes and enhancements across multiple modules including 3D mesh rendering, numpy utilities, and vertebra constants. The changes address computation logic errors, add new parameters for enhanced functionality, and fix type annotations.
- Fixes computation bugs in surface calculation and normalization functions
- Adds new parameters for scale factor control and channel-wise dilation
- Corrects file path handling and method calls in mesh operations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TPTBox/mesh3D/snapshot3D.py | Adds type annotations, scale_factor parameter, and fixes method calls with additional arguments |
| TPTBox/mesh3D/mesh.py | Fixes file extension concatenation, directory validation logic, and adds HTML export functionality |
| TPTBox/core/vert_constants.py | Adds missing has_rib attribute assignment and fixes C6 vertebra definition |
| TPTBox/core/np_utils.py | Fixes surface computation logic and adds new parameters for enhanced Gaussian smoothing |
| TPTBox/core/nii_wrapper.py | Fixes normalization calculation bug and adds new smoothing parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| C4 = 4 | ||
| C5 = 5 | ||
| C6 = 6 | ||
| C6 = 6, True, True |
There was a problem hiding this comment.
The C6 vertebra definition is inconsistent with other entries. It should follow the same pattern as other vertebrae (e.g., C6 = 6 or include proper parameter names if the tuple format is intentional).
Suggested change
| C6 = 6, True, True | |
| C6 = 6 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… into snapshot_readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.