feature:access-control deactivate_entity should also emit access-revoked events for active permissions#367
Open
Emmanuelluxury wants to merge 3 commits into
Open
Conversation
added 3 commits
May 29, 2026 17:25
…nsaction overhead
…vent memory exhaustion
…ked events for active permissions
|
@Emmanuelluxury Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #338
Description
The deactivate_entity function emits a deactivation event but does not emit access-revoked events for all the active consents and permissions held by the deactivated entity. External systems listening for access-revoked events (e.g., audit loggers) will miss these implicit revocations.
Expected Behavior
When an entity is deactivated, iterate its active permissions and emit an access-revoked event for each one, or emit a single deactivation event that downstream consumers can treat as revoking all access.
Contract
contracts/access-control