Open
Conversation
Contributor
|
Hey @annh3 excited for first PR :D! However, first this should be cleaned up a bit- (a) there seem to be a huge number of changes (92 files changed...). PRs should ideally be about one isolated addition / logical unit. Then, (b) there are unresolved conflicts (although fixing (a) will probably resolve) Anyway, once you take care of this, you can assign me and/or @jdunnmon as a reviewer and we'll get a notification! |
|
Ah @annh3 , I think you want this PR to be from your branch to the jdunnmon:ddsm-keras branch, not to hazy:master. That latter one is a much bigger piece of work. Definitely assign me as a reviewer for this one when you respecify the branches! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding image saving to keras pipeline
should fetch keras_binding/tan_numpy_array_iterator.py
and keras_binding/tanda_keras.py