Skip to content

Ddsm keras#9

Open
annh3 wants to merge 2 commits intoHazyResearch:masterfrom
jdunnmon:ddsm-keras
Open

Ddsm keras#9
annh3 wants to merge 2 commits intoHazyResearch:masterfrom
jdunnmon:ddsm-keras

Conversation

@annh3
Copy link

@annh3 annh3 commented Jan 15, 2018

Adding image saving to keras pipeline

should fetch keras_binding/tan_numpy_array_iterator.py
and keras_binding/tanda_keras.py

@ajratner
Copy link
Contributor

Hey @annh3 excited for first PR :D! However, first this should be cleaned up a bit- (a) there seem to be a huge number of changes (92 files changed...). PRs should ideally be about one isolated addition / logical unit. Then, (b) there are unresolved conflicts (although fixing (a) will probably resolve)

Anyway, once you take care of this, you can assign me and/or @jdunnmon as a reviewer and we'll get a notification!

@jdunnmon
Copy link

Ah @annh3 , I think you want this PR to be from your branch to the jdunnmon:ddsm-keras branch, not to hazy:master. That latter one is a much bigger piece of work. Definitely assign me as a reviewer for this one when you respecify the branches!

@jdunnmon jdunnmon deleted the ddsm-keras branch January 15, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants