Closed
Conversation
Gama11
reviewed
Sep 22, 2019
|
|
||
| package haxe; | ||
|
|
||
| #if (target.asys) |
Member
There was a problem hiding this comment.
I think it's no longer necessary to put dot-defines in parens?
Gama11
reviewed
Sep 22, 2019
| com.package_rules <- PMap.add "sys" Forbidden com.package_rules; | ||
| if com.config.pf_asys then begin | ||
| raw_define_value com.defines "target.asys" "true"; | ||
| define com Define.Asys |
Member
There was a problem hiding this comment.
Why have both target.asys and asys? I thought the defines not prefixed by target. are just for backwards compatibility.
Member
There was a problem hiding this comment.
If we have sys we should also have asys, otherwise this is just one giant trap.
# Conflicts: # libs/uv/uv_stubs.c
Aurel300
commented
Sep 24, 2019
Aurel300
commented
Sep 24, 2019
Member
|
See #8831. Branch will be kept to experiment further, but we don't need an open long-term PR for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of HXP-0010.
Note: this PR has been split into #8831 and #8832, in addition to the target-specific PRs:
TODO
sys.io.FileInputandsys.io.FileOutputwere loaded hackily, this was moved toStdimports - maybe that's not good enough?-dce nois required for the tests not to hang