Conversation
doesn't seem to be a reason for them to be in FlxCameraView? if I've overlooked something then we can easily move them back at some later point in time
WIP; debug drawing is not functional yet and there's a bunch of temporary code that needs to be cleaned up
the code hidden by this check is generally valid for any other non-blitting renderer like opengl
| * references to Graphic need to be removed first | ||
| */ | ||
| @:forward | ||
| abstract FlxVertexBuffer(Graphics) from Graphics to Graphics |
There was a problem hiding this comment.
One thing that stuck out to me, I think this name is a bit misleading. This seems more of some kind of canvas than it is a vertex buffer. Maybe a name like FlxCanvas would be better?
There was a problem hiding this comment.
Lol, I spent so long trying to think of another name and eventually was like "just go with this and hope ACrazyTown suggests something better". I like it
I think there's other badly named things, so poke around and lmk
|
@ACrazyTown gonna type up a summary and some of my immediate plans. There's also this:Geokureli#5 which gave me nightmares There's a lot of things that just suck in the old way, and if we're going to add new ways to do them we should make them not suck, otherwise we're gonna be back here, deprecating all of these new methods when we make the better system. That's why I added the wrappers for graphics and vector (in the other pr). I think we should also consider adding FlxTexture, now for this reason. After my summary, I'm gonna test all the demos now (for real, this time). If it fails on #5 I'll test it on this branch if it fails on both I'll test it on yours, then dev until I know which set of changes caused it |
Some ideas:
|
I think it might be better to leave the batching as-is for now as it's specific to the drawQuads renderer. I'll start working on implementing the GL renderer to the abstraction, having two hardware accelerated renderers might make it easier to reason about things I'm a bit worried about tying the render methods to the camera view but I suppose this boils back to my previous sentence
I have a draft (as discussed in #3540) for this typed up in a branch somewhere. It's implemented as a new class rather than an abstract so there is a bit of friction with implementing it with existing systems. Will need to revisit it and clean it up |
|
Also, maybe it'd be a good idea to merge this into a feature branch in the Flixel repo here. That way both of us can make PRs to that instead of going back and forth between our forks |
| visibleCount = Std.int(divide(visibleCount, _visibleObjectMarker)); | ||
|
|
||
| if (FlxG.renderTile) | ||
| if (FlxG.renderer.blit) |
There was a problem hiding this comment.
| if (FlxG.renderer.blit) | |
| if (FlxG.renderer.tile) |
This broke the "DrawQuads" stats in the debugger
testing CI. may PR here, instead: https://github.com/ACrazyTown/flixel/compare/seperate-renderer...Geokureli:flixel:geo-separate-renderer?expand=1