Skip to content

Fix type of uint_64_property from uint32 to uint64 in simple_message.proto #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Havret merged 2 commits into from
Nov 20, 2025
Merged

Fix type of uint_64_property from uint32 to uint64 in simple_message.proto #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fbaf98
Fix type of uint_64_property from uint32 to uint64 in simple_message.…
Havret Nov 20, 2025
82e8f7b
Fix number type conversion to use invariant culture in FieldConverter
Havret Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Protobuf.System.Text.Json/InternalConverters/FieldConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System.Buffers;
using System.Diagnostics;
using System.Globalization;
using System.Text.Json;
using System.Text.Json.Serialization;
using Google.Protobuf;
Expand Down Expand Up @@ -37,7 +38,7 @@ public override void Read(ref Utf8JsonReader reader, IMessage obj, Type typeToCo

if (_isConverterForNumberType && reader.TokenType == JsonTokenType.String && (JsonNumberHandling.AllowReadingFromString & options.NumberHandling) != 0)
{
var value = Convert.ChangeType(reader.GetString(), typeToConvert);
var value = Convert.ChangeType(reader.GetString(), typeToConvert, CultureInfo.InvariantCulture);
fieldAccessor.SetValue(obj, value);
}
else
Expand Down
2 changes: 1 addition & 1 deletion test/Protobuf.System.Text.Json.Tests/Protos/simple_message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ message SimpleMessage {

uint32 uint_32_property = 5;

uint32 uint_64_property = 6;
uint64 uint_64_property = 6;

sint32 sint_32_property = 7;

Expand Down