Fix: log full exception instead of ex.Message in GetHoldingInformation#33
Open
HashidaTKS wants to merge 1 commit into
Open
Fix: log full exception instead of ex.Message in GetHoldingInformation#33HashidaTKS wants to merge 1 commit into
HashidaTKS wants to merge 1 commit into
Conversation
…ion catch LoggerWrapper.Warn(ex.Message) discards the stack trace and inner exception, making it impossible to determine where an error originated. Change to LoggerWrapper.Warn(ex) to preserve the full exception information. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題点
Scraper.GetHoldingInformation()の catch ブロックでLoggerWrapper.Warn(ex.Message)を使用していた（line 405）。ex.Messageのみでは、スタックトレースや InnerException が記録されないため、例外の発生箇所や根本原因を特定することが困難だった。改善内容
LoggerWrapper.Warn(ex.Message)→LoggerWrapper.Warn(ex)に変更Test plan
🤖 Generated with Claude Code