fix(pkgmanager): prevent nil pointer dereference on malformed boss.json (issues #177, #178)#250
Open
isaquepinheiro wants to merge 1 commit into
Open
Conversation
isaquepinheiro
force-pushed
the
bugfix/issue-177-safe-package-load
branch
from
0483354 to
8a32be9
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage ? 25.60%
=======================================
Files ? 82
Lines ? 3827
Branches ? 0
=======================================
Hits ? 980
Misses ? 2773
Partials ? 74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds safety checks to the package manager to prevent nil pointer dereference panics when loading corrupted or invalid boss.json package descriptors.