Split your chessboard file, and added some modularity

[nicvagn]

No description provided.

[nicvagn]

I did a major re-due of your chessboard file and split it into some small more maintainable chunks.

I also tried to associate boards and move_handlers. It is not perfect, and will probably need some review/tweaking.

But, I think breaking up the monolithic chessboard.py now, will really aid in producing a more maintainable codebase rather than going down the road of the other project and putting too much in one file.

We need to look towards the future now, and make a good base to build from.

I also did some work towards creating a game class. It is rough and early in development.

The game feature branch is not mature, but I believe that we need to work closely together, especially while the code base is young.

This is to prevent our individual contrabution's from diverging too much, and becoming irreconcilable.

[HarshilPatel007]

Hi @nicvagn , thanks.

Can you please set target branch to the dev branch instead of main.

main is for our stable source code.

I'll review the code once it get finished.

Please follow this commit messages.

Type	Title	Description
feat	Features	A new feature
fix	Bug Fixes	A bug fix
docs	Documentation	Documentation only changes
style	Styles	Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
refactor	Code Refactoring	A code change that neither fixes a bug nor adds a feature
perf	Performance Improvements	A code change that improves performance
test	Tests	Adding missing tests or correcting existing tests
build	Builds	Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
ci	Continuous Integrations	Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
chore	Chores	Other changes that don't modify src or test files
revert	Reverts	Reverts a previous commit
initial	Initial	Initial commit

Example:
If you're working on a feature & it's still not completed,

feat(short description of feature): WIP
- what you've done

If you're working on a feature & it's completed,

feat(short description of feature): DONE
- what you've done

for bug fix,

fix(short description): DONE
- what you've done

or if you've done multiple things in a single shot,
just write it down as this,

fix(short description): DONE
- what you've done

feat(short description of feature): DONE
- what you've done

docs(update README): DONE

refactor(short description): DONE
- what you've done

So, it'll be easy to organize repo. And please no bad words 😄 .

[nicvagn]

Ok. Sorry for that. It is my first pull request 😄

…

On Thu, Feb 29, 2024, 11:52 p.m. Harshil Patel ***@***.***> wrote: Hi @nicvagn <https://github.com/nicvagn> , thanks. Can you please set target branch to the dev branch instead of main. main is for our stable source code. I'll review the code — Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI6335THKVPARPIZEOJGPPDYWAJTHAVCNFSM6AAAAABEAH6PISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSGU2TQNBXGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[HarshilPatel007]

@nicvagn , no worries. It happens. 😃

I'd advise you to stop working until the core chessboard work is done. (However you can continue working on it.)
Because, move table will not work if we want to do a comment, variant/sub-variations support.
Currently, I'm working on an engine support.
Pretty much done.(Thanks to ChatGPT for help)😄
And we've to add moves support like chessbase does.

[nicvagn]

Sure, I maybe I should hold of a bit until the chessboard is more mature. But, I still think you should have games, not chessboards as the base organization object. It should make things easier in the long term.

Cheers, nrv

[HarshilPatel007]

Sure, I maybe I should hold of a bit until the chessboard is more mature. But, I still think you should have games, not chessboards as the base organization object. It should make things easier in the long term.

Cheers, nrv

Hi @nicvagn,
you can help in on going engine branch where engine vs engine isn't working and if white selects as engine then problem arise in highlighting squares. (without highlighting squares, it works) means, very first move of white moved without highlighting a source and destination squares.

[nicvagn]

Ok, I have some family stuff going on rn. I will look at it when that is resolved