-
Notifications
You must be signed in to change notification settings - Fork 0
test: adding backend/e2e tests #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HardMax71
wants to merge
12
commits into
main
Choose a base branch
from
test/backend-e2e
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,792
−4,913
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a61cca3
missing e2e tests
HardMax71 c95df47
fixed test fails
HardMax71 4a935e5
all evetnt types as strs -> EventType; updated usage places
HardMax71 73a3f19
fix of tests + fix of di for replay service
HardMax71 fa9c489
fix of tests + fix of di for replay service
HardMax71 a481350
updated tests - tests for happy paths are using pydantic models from …
HardMax71 a13b1a4
resource cleaner fix: getting k8s stuff from DI
HardMax71 7ae6b28
fxing schemas, tests, such stuff
HardMax71 77e92d1
fixes
HardMax71 bd2a60f
fixes
HardMax71 b6919d2
tests update - removed kafka prefix, simplified multithread testing i…
HardMax71 5b439ac
removed integration tests, moved all of them to e2e, also updated docs
HardMax71 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle
ExecutionNotFoundErrorto return 404 instead of 500.The
get_execution_resultmethod raisesExecutionNotFoundErrorwhen the execution doesn't exist (per the relevant code snippet). This exception will propagate as an unhandled 500 error. Consider catching it and returning a proper 404 response.🐛 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents