Re-enable MAIL#1769
Open
NotLivyathan wants to merge 4 commits into
Open
Conversation
Collaborator
Author
|
Oops. |
Collaborator
what do you mean oops |
Collaborator
Author
Accidental commits to the wrong branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Does as it says. Also comes with some slight theoretical improvements to the mail system to hopefully mitigate any potential substantial lag it could cause.
Why / Balance
Mail Carriers literally have no reason to exist right now, and despite being an MRP server, people can't really figure out how to do mail on their own without this.
Technical details
Restored sector-wide player mail by re-adding SectorMail to the mail sector service, which reactivates the existing mail teleporter spawn loop. Adjusted recipient selection so each mail wave shuffles the active recipient pool and hands out deliveries without replacement before any repeat can happen, preventing one player from getting most or all of a wave by chance.
Also cleaned up the mail path a bit as part of that work: reduced per-wave allocation churn in parcel selection, simplified the undelivered-parcel count check, and throttled the “no valid teleporters” / “no candidates” logs so they only fire on state transitions instead of every mail interval.
Breaking changes
Mail. Maybe.
Changelog
🆑