New world generation by fenndragon · Pull Request #1592 · HardLightSector/HardLight

fenndragon · 2026-05-02T23:20:47Z

About the PR

Why / Balance

Technical details

How to test

Media

Breaking changes

Changelog

* now you see me * unused depen * test fail fix attempt 1 * test fail fix attempt 2 * fix test fail attempt 3 * shot in the dark. * Does this work? * import cleanup * taking a shot at this. * Convert PersistenceSaveCommand to LocalizedEntityCommands. * requested changes * requested changes. also dealt with improperly named private const * Update Content.Server/GameTicking/GameTicker.Spawning.cs Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> * Update Content.Server/GameTicking/GameTicker.Spawning.cs Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> * Convert PlanetCommand to LocalizedEntityCommand * Update BiomeSystem.cs * Update Content.Server/Salvage/SalvageSystem.Runner.cs Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> * Update Content.Server/Procedural/DungeonSystem.Rooms.cs Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> * Update Content.Server/Salvage/SpawnSalvageMissionJob.cs Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> * Update Content.Server/Station/Systems/StationBiomeSystem.cs Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com> * revert to latest master. * slartis suggestion. * Update SetMapAtmosCommand.cs * cleanup * Update PersistenceSaveCommand.cs * finish localizing persistencesavecommand * this is icky, I change. * :sigh: * revert whatever I did here? * oh I see, some inconsistencies. * revert this * Update PlanetCommand.cs * move this ftl to the commands folder --------- Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* weather status effect entities * proto port + fixes * Update weather.yml * fix visuals * Update SharedWeatherSystem.cs * Update SharedWeatherSystem.cs * Update WeatherSystem.cs * Thanks Slarti, thats a much better * Update WeatherSystem.cs * Update StencilOverlay.Weather.cs * Update Content.Client/Overlays/StencilOverlay.Weather.cs Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com> * Update Content.Shared/StatusEffectNew/Components/StatusEffectComponent.cs Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com> * Update Content.Client/Overlays/StencilOverlay.Weather.cs Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com> * Revise weather command help descriptions Updated weather command help texts for clarity. * Merge branch 'master' into ed-14-11-2025-weather-entities * Tayrtahn review apply * fixes and cleanup --------- Co-authored-by: Pok <113675512+Pok27@users.noreply.github.com> Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

…null' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

github-actions · 2026-05-02T23:20:57Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

ShadesMars · 2026-05-02T23:35:17Z

I see this has the new weather from wizden, i will say its works.

HOWEVER, some weather errors sometimes happents, do not also port the sand+weather effect from it as currently its just, does not work (ive have to fix it on SL)

fenndragon · 2026-05-04T18:42:35Z

I see this has the new weather from wizden, i will say its works.

HOWEVER, some weather errors sometimes happents, do not also port the sand+weather effect from it as currently its just, does not work (ive have to fix it on SL)

I really need to just... Redo weather in general. It's awful in any method it's been set up so far.

Fasuh

some changes that were never discussed, as well as completely random changes to unrelated systems once again, please clean the PR from unrelated changes,

For things that potentially throw off balance i would massively appreciate having a discussion for it as per this announcement
https://discord.com/channels/1380477227912925194/1380489720101998654/1501609020308328528

though i am aware that these changes are marked as not ready yet, i prefer marking things that are problematic ahead of time.

Fasuh · 2026-05-10T14:47:48Z

                                    <Label Text="{Loc 'humanoid-profile-editor-height-label'}" />
                                    <Control HorizontalExpand="True"/>
-                                    <Slider Name="HeightSlider" MinValue="0.8" MaxValue="1.2" Value="1.0" HorizontalAlignment="Right" MinSize="200 0" />
+                                    <Slider Name="HeightSlider" MinValue="0.4" MaxValue="1.5" Value="1.0" HorizontalAlignment="Right" MinSize="200 0" />


Unrelated change.

Fasuh · 2026-05-10T14:47:51Z

                                    <Label Text="{Loc 'humanoid-profile-editor-width-label'}" />
                                    <Control HorizontalExpand="True"/>
-                                    <Slider Name="WidthSlider" MinValue="0.8" MaxValue="1.2" Value="1.0" HorizontalAlignment="Right" MinSize="200 0" />
+                                    <Slider Name="WidthSlider" MinValue="0.4" MaxValue="1.5" Value="1.0" HorizontalAlignment="Right" MinSize="200 0" />


Unrelated change.

Fasuh · 2026-05-10T14:47:57Z

            HeightSlider.OnValueChanged += args =>
            {
-                SetHeight((float)args.Value);
+                SetProfileHeight((float)args.Value);


Unrelated change.

Fasuh · 2026-05-10T14:57:32Z

@@ -0,0 +1,198 @@
+# Sector Worldgen Rewrite


this is not needed in a PR

Fasuh · 2026-05-10T15:02:54Z

+    public float MaxTemperature = 360f;
+
+    [DataField]
+    public float MinOxygen = 0f;


I dont believe limiting atmos to o2, n2, and co2 was ever communicated to the players, this is a massive change for atmosian ships.

Yeah I've been really on the 'no' end from all of this if it's going to be another wholesale replacement of expeds for this exact reason.

jimmy12or · 2026-05-11T00:52:48Z

Does this make current exped disks 100% pointless?

github-actions · 2026-05-16T15:00:54Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

fenndragon and others added 30 commits April 26, 2026 14:39

first step

982f270

new touches

7f5ea93

fix

de702d4

planetside generation

9ca82ee

fixes

b30eca6

fix

615107c

fixes

f60f9b1

fix

03d7e41

fix

9c0b9a9

Update weather.yml

a016657

Update PersistenceSaveCommand.cs

c85e74b

Update SectorWorldSystem.cs

351a553

fixes

564cb3f

fix

cbf9c71

Update salvage_mods.yml

4ca9736

fix

c7598d0

fix

058d53c

fix

de1477d

fix

55eb0d4

Update SectorWorldExpeditionIntegrationTest.cs

6a9f44d

fix

cd86564

fixes

232b3bb

Merge branch 'master' into new-world-generation-

5074603

Potential fix for pull request finding 'Dereferenced variable may be …

5f95eee

…null' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Dereferenced variable may be …

0e97dde

…null' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Dereferenced variable may be …

ee74c77

…null' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Dereferenced variable may be …

048ab7a

…null' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

Potential fix for pull request finding 'Dereferenced variable may be …

14b7f3e

…null' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

fenndragon added 6 commits April 30, 2026 17:16

fixes

46817b9

fixes

954fd32

Update SectorWorldSystem.cs

6b4fb84

Update GatewaySystem.cs

4922f1d

fix

01010e7

fixes

ca49ec2

github-actions Bot added size/L S: Untriaged UI C# Docs FTL YML S: Merge Conflict and removed S: Untriaged size/L labels May 2, 2026

Merge branch 'master' into new-world-generation-

e00f5eb

github-actions Bot added size/L and removed S: Merge Conflict labels May 2, 2026

fenndragon added do not merge Circumstances mean the PR should not be merged until the label is removed frozen Rework/Feature Discussion labels May 4, 2026

Kronyxxx removed the Docs label May 6, 2026

Fasuh reviewed May 10, 2026

View reviewed changes

github-actions Bot added the S: Merge Conflict label May 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New world generation #1592

New world generation #1592
fenndragon wants to merge 52 commits into
masterfrom
new-world-generation-

fenndragon commented May 2, 2026

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

ShadesMars commented May 2, 2026

Uh oh!

fenndragon commented May 4, 2026

Uh oh!

Fasuh left a comment

Uh oh!

Fasuh May 10, 2026

Uh oh!

Fasuh May 10, 2026

Uh oh!

Fasuh May 10, 2026

Uh oh!

Fasuh May 10, 2026

Uh oh!

Fasuh May 10, 2026

Uh oh!

TeliaRS643 May 10, 2026

Uh oh!

jimmy12or commented May 11, 2026

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

fenndragon commented May 2, 2026

About the PR

Why / Balance

Technical details

How to test

Media

Breaking changes

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

ShadesMars commented May 2, 2026

Uh oh!

fenndragon commented May 4, 2026

Uh oh!

Fasuh left a comment

Choose a reason for hiding this comment

Uh oh!

Fasuh May 10, 2026

Choose a reason for hiding this comment

Uh oh!

Fasuh May 10, 2026

Choose a reason for hiding this comment

Uh oh!

Fasuh May 10, 2026

Choose a reason for hiding this comment

Uh oh!

Fasuh May 10, 2026

Choose a reason for hiding this comment

Uh oh!

Fasuh May 10, 2026

Choose a reason for hiding this comment

Uh oh!

TeliaRS643 May 10, 2026

Choose a reason for hiding this comment

Uh oh!

jimmy12or commented May 11, 2026

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants