-
Notifications
You must be signed in to change notification settings - Fork 630
Add Roc's Feather (custom item) to Rando Item Pool #6035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
played around with it a little, would be up for adding Roc's Feather logic post hoc
|
I wanted to get this into mainline Ship but apparently how I envisioned the item wasn't what was required for rando, so I'm keeping this on my own fork from now on. |
|
Re-opening this one last time because I'm genuinely torn to see the effort go to waste because someone else wants the item to be something else. I've updated the PRs first message to make clear what I'm willing to change and what I'm not willing to change. Take it or leave it. |
This adds Roc's as a fully implemented item into the randomizer pool. When both Roc's and Nayru's is found, you can swap between them on the pause menu. This does not have logic tied to it nor do I really plan on adding it. It has a custom icon, GI model and animation, and supports the item tracker by adding it to the main window when Roc's is shuffled.
If you want to use kentonm's animation for Roc's that's used in the Indigo romhack, you can drop the o2r in this zip into the mods folder:
rocs_feather_animation_kentonm_indigo.zip
Many people have contributed to this over time, so huge shoutout to:
After constant conflict with a different team member, I'm changing my stance. If this wants to make it into Ship, I'm willing to do bug fixes and address code reviews. I'm not willing to change the behaviour of Rocs Feather, and I won't go into discussion about it. If it's not good enough as is, then close this.
Build Artifacts