Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
d3e62dd
Remove CVar Middleman and fix rando presets
leggettc18 Mar 22, 2025
baa4fd7
Throwing in a couple of typo corrections
leggettc18 Mar 22, 2025
3e783e9
Initial build of integrated rando menu
leggettc18 Mar 23, 2025
fca7d33
Actually working integrated menu
leggettc18 Mar 23, 2025
5011c55
Merge branch 'develop' into feat/randomizer/modern-menu-integration
leggettc18 Dec 10, 2025
84daf0c
Fix off-by-one-bug with spoiler excluded locations writing.
leggettc18 Dec 10, 2025
b351ad0
Initial pass at modern locations menu.
leggettc18 Dec 10, 2025
f179224
Initial pass at modern tricks/logic menu.
leggettc18 Dec 10, 2025
e370340
Fix tricksDirty tracking
leggettc18 Dec 10, 2025
08d9c29
Remove non-integrated settings.
leggettc18 Dec 10, 2025
bcd0e04
Replace UpdateOptionProperties with per-option callback functions.
leggettc18 Dec 11, 2025
2425084
WIP removing the old window completely
leggettc18 Dec 11, 2025
d1a43ba
Implement new check for rando thread join
leggettc18 Dec 11, 2025
5918c89
WIP menu reorganization
leggettc18 Dec 11, 2025
3da8257
Finish menu reorganization
leggettc18 Dec 11, 2025
81b30a1
Finish removal of RandomizerSettingsWindow
leggettc18 Dec 11, 2025
145ecf3
Properly handle column count in AddWidgets
leggettc18 Dec 12, 2025
f5f6264
More removal of now-unused stuff
leggettc18 Dec 12, 2025
46415e0
clang-format
leggettc18 Dec 12, 2025
e43a364
Added missing widget for RSK_BRIDGE_OPTIONS
leggettc18 Dec 12, 2025
a25bebe
Remove previously added header guards
leggettc18 Dec 12, 2025
20b2d56
Remove commented line
leggettc18 Dec 12, 2025
62d8222
Merge some common code between callbacks
leggettc18 Dec 15, 2025
5035e12
Fix typo
leggettc18 Dec 15, 2025
830e15f
Left TODO comment to fix an issue that is out of scope for this PR
leggettc18 Dec 15, 2025
f94a40c
clang-format
leggettc18 Dec 15, 2025
25f35c5
removes unecessary calloc
leggettc18 Dec 18, 2025
b83a1fb
Finish menu reorganization
leggettc18 Jan 1, 2026
9634b2c
Fix incorrect spacing from merge
leggettc18 Jan 1, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/ExtraModes/MirroredWorld.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "soh/Enhancements/cosmetics/authenticGfxPatches.h"
#include "soh/Enhancements/game-interactor/GameInteractor_Hooks.h"
#include "soh/Enhancements/randomizer/3drando/random.hpp"
#include "soh/Enhancements/randomizer/context.h"
#include "soh/Enhancements/randomizer/SeedContext.h"
#include "soh/Enhancements/enhancementTypes.h"
#include "soh/ResourceManagerHelpers.h"
#include "soh/ShipInit.hpp"
Expand Down
4 changes: 1 addition & 3 deletions soh/soh/Enhancements/Presets/Presets.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include "soh/SohGui/MenuTypes.h"
#include "soh/SohGui/SohMenu.h"
#include "soh/SohGui/SohGui.hpp"
#include "soh/Enhancements/randomizer/randomizer_settings_window.h"
#include "soh/Enhancements/randomizer/randomizer_check_tracker.h"
#include "soh/Enhancements/randomizer/randomizer_entrance_tracker.h"
#include "soh/Enhancements/randomizer/randomizer_item_tracker.h"
Expand All @@ -20,7 +19,6 @@ namespace fs = std::filesystem;

namespace SohGui {
extern std::shared_ptr<SohMenu> mSohMenu;
extern std::shared_ptr<RandomizerSettingsWindow> mRandomizerSettingsWindow;
} // namespace SohGui

struct PresetInfo {
Expand Down Expand Up @@ -124,7 +122,7 @@ void applyPreset(std::string presetName, std::vector<PresetSection> includeSecti
}
}
if (i == PRESET_SECTION_RANDOMIZER) {
SohGui::mRandomizerSettingsWindow->SetNeedsUpdate();
Rando::Settings::GetInstance()->UpdateAllOptions();
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/TimeSavers/SkipCutscene/SkipIntro.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "soh/Enhancements/game-interactor/GameInteractor.h"
#include "soh/Enhancements/randomizer/context.h"
#include "soh/Enhancements/randomizer/SeedContext.h"
#include "soh/ShipInit.hpp"

extern "C" {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "soh/Enhancements/game-interactor/GameInteractor.h"
#include "soh/Enhancements/game-interactor/GameInteractor_Hooks.h"
#include "soh/Enhancements/randomizer/context.h"
#include "soh/Enhancements/randomizer/SeedContext.h"
#include "soh/ShipInit.hpp"

extern "C" {
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/enemyrandomizer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#include "functions.h"
#include "macros.h"
#include "soh/Enhancements/randomizer/3drando/random.hpp"
#include "soh/Enhancements/randomizer/context.h"
#include "soh/Enhancements/randomizer/SeedContext.h"
#include "soh/Enhancements/enhancementTypes.h"
#include "variables.h"
#include "soh/OTRGlobals.h"
Expand Down
1 change: 1 addition & 0 deletions soh/soh/Enhancements/item-tables/ItemTableTypes.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#pragma once

#ifdef __cplusplus
#include <stdint.h>
#endif
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/3drando/fill.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "fill.hpp"

#include "../dungeon.h"
#include "../context.h"
#include "../SeedContext.h"
#include "item_pool.hpp"
#include "random.hpp"
#include "spoiler_log.hpp"
Expand Down
2 changes: 2 additions & 0 deletions soh/soh/Enhancements/randomizer/3drando/fill.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,5 @@ void GeneratePlaythrough();
bool CheckBeatable(RandomizerGet ignore = RG_NONE);

void ValidateEntrances(bool checkOtherEntranceAccess);

void ValidateEntrances(bool checkPoeCollectorAccess, bool checkOtherEntranceAccess);
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/3drando/hint_list.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "custom_messages.hpp"

#include "../randomizerTypes.h"
#include "../context.h"
#include "../SeedContext.h"
#include "../static_data.h"

using namespace CustomMessages;
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/3drando/item_pool.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#include "../dungeon.h"
#include "fill.hpp"
#include "../static_data.h"
#include "../context.h"
#include "../SeedContext.h"
#include "pool_functions.hpp"
#include "random.hpp"
#include "spoiler_log.hpp"
Expand Down
5 changes: 3 additions & 2 deletions soh/soh/Enhancements/randomizer/3drando/playthrough.hpp
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
#pragma once

#include <string>
#include <set>
#include "../context.h"
#include "../SeedContext.h"

namespace Playthrough {
int Playthrough_Init(uint32_t seed, std::set<RandomizerCheck> excludedLocations,
std::set<RandomizerTrick> enabledTricks);
int Playthrough_Repeat(std::set<RandomizerCheck> excludedLocations, std::set<RandomizerTrick> enabledTricks,
int count = 1);
} // namespace Playthrough
} // namespace Playthrough
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/3drando/rando_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#include "../item_location.h"
#include "../location_access.h"
#include "rando_main.hpp"
#include "../context.h"
#include "../SeedContext.h"
#include <libultraship/bridge.h>
#include <ship/Context.h>
#include <libultraship/libultra/types.h>
Expand Down
3 changes: 2 additions & 1 deletion soh/soh/Enhancements/randomizer/3drando/rando_main.hpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
#pragma once

#include "soh/Enhancements/randomizer/item.h"

#include <set>
namespace RandoMain {
void GenerateRando(std::set<RandomizerCheck> excludedLocations, std::set<RandomizerTrick> enabledTricks,
std::string seedInput);
}
}
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/3drando/shops.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#pragma once
#include "../context.h"
#include "../SeedContext.h"

#include <vector>
#include <array>
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/3drando/spoiler_log.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ std::string RemoveLineBreaks(std::string s) {
static void WriteExcludedLocations() {
auto ctx = Rando::Context::GetInstance();

for (size_t i = 1; i < Rando::Settings::GetInstance()->GetExcludeLocationsOptions().size(); i++) {
for (size_t i = 0; i < Rando::Settings::GetInstance()->GetExcludeLocationsOptions().size() - 1; i++) {
for (const auto& location : Rando::Settings::GetInstance()->GetExcludeLocationsOptions()[i]) {
if (ctx->GetLocationOption(static_cast<RandomizerCheck>(location->GetKey())).Get() == RO_LOCATION_INCLUDE) {
continue;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "starting_inventory.hpp"

#include "../dungeon.h"
#include "../context.h"
#include "../SeedContext.h"
#include "../logic.h"
#include "pool_functions.hpp"
#include "soh/Enhancements/randomizer/static_data.h"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "context.h"
#include "SeedContext.h"
#include "static_data.h"
#include "soh/OTRGlobals.h"
#include "soh/Enhancements/item-tables/ItemTableManager.h"
Expand Down Expand Up @@ -620,4 +620,4 @@ uint32_t Context::GetSeed() const {
void Context::SetSeed(const uint32_t seed) {
mFinalSeed = seed;
}
} // namespace Rando
} // namespace Rando
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/dungeon.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#include "3drando/pool_functions.hpp"
#include "static_data.h"
#include "context.h"
#include "SeedContext.h"

namespace Rando {
DungeonInfo::DungeonInfo(std::string name_, const RandomizerHintTextKey hintKey_, const RandomizerGet map_,
Expand Down
3 changes: 2 additions & 1 deletion soh/soh/Enhancements/randomizer/entrance.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#pragma once

#ifdef __cplusplus

#include "randomizerTypes.h"
Expand Down Expand Up @@ -157,4 +158,4 @@ extern "C" {
EntranceOverride* Randomizer_GetEntranceOverrides();
#ifdef __cplusplus
}
#endif
#endif
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/hint.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "hint.h"
#include "map"
#include "string"
#include "context.h"
#include "SeedContext.h"
#include <spdlog/spdlog.h>
#include "static_data.h"

Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/item.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#include "item.h"
#include "item_location.h"

#include "context.h"
#include "SeedContext.h"
#include "logic.h"
#include "3drando/item_pool.hpp"
#include "z64item.h"
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/item_list.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "static_data.h"
#include "context.h"
#include "SeedContext.h"
#include "logic.h"
#include "z64object.h"
#include "soh/Enhancements/custom-message/CustomMessageTypes.h"
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/item_location.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "item_location.h"
#include "context.h"
#include "SeedContext.h"
#include "logic.h"

namespace Rando {
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/location_access.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

#include "soh/Enhancements/randomizer/dungeon.h"
#include "soh/Enhancements/randomizer/static_data.h"
#include "soh/Enhancements/randomizer/context.h"
#include "soh/Enhancements/randomizer/SeedContext.h"
#include "soh/Enhancements/randomizer/3drando/item_pool.hpp"
#include "soh/Enhancements/randomizer/3drando/spoiler_log.hpp"
#include "soh/Enhancements/randomizer/trial.h"
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/location_access.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include <set>

#include "soh/Enhancements/randomizer/randomizerTypes.h"
#include "soh/Enhancements/randomizer/context.h"
#include "soh/Enhancements/randomizer/SeedContext.h"
#include "soh/Enhancements/randomizer/logic.h"

#define TIME_PASSES true
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/location_list.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "static_data.h"
#include "z64save.h"
#include "context.h"
#include "SeedContext.h"
#include "dungeon.h"

std::array<Rando::Location, RC_MAX> Rando::StaticData::locationTable;
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/logic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include "soh/OTRGlobals.h"
#include "dungeon.h"
#include "context.h"
#include "SeedContext.h"
#include "macros.h"
#include "variables.h"
#include <spdlog/spdlog.h>
Expand Down
2 changes: 1 addition & 1 deletion soh/soh/Enhancements/randomizer/logic.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#pragma once

#include "randomizerTypes.h"
#include "context.h"
#include "SeedContext.h"
#include <cstdint>

namespace Rando {
Expand Down
Loading
Loading