Skip to content

File Select More Info Update#5998

Merged
serprex merged 10 commits intoHarbourMasters:developfrom
Pepe20129:file_select_more_info_update
Jan 2, 2026
Merged

File Select More Info Update#5998
serprex merged 10 commits intoHarbourMasters:developfrom
Pepe20129:file_select_more_info_update

Conversation

@Pepe20129
Copy link
Copy Markdown
Contributor

@Pepe20129 Pepe20129 commented Nov 29, 2025

This PR massively improves the "File Select More Info" enhancement:

  • Moves it to a separate file
  • Moves it to VB
  • Adds triforce pieces & fishing pole
  • General cleanup

Build Artifacts

Copy link
Copy Markdown
Contributor

@Malkierian Malkierian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works perfectly from what I can tell. Has a new conflict, though.

// using 0xB0 and later as they're not real item ids
// TODO: improve this (RandomizerGet doesn't work)

// disabled due to lus issue
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please expand, ideally link to issue on lus issue tracker

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't made an issue yet, but I mentioned it in the discord.

@serprex serprex merged commit 9e6c9a4 into HarbourMasters:develop Jan 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants