Conversation
refs TryGhost#9742, refs TryGhost#9724 - handle König Editor format for 2.0 - adapted importer to be able to import 1.0 and 2.0 exports - added migration scripts - remove labs flag for Koenig - migrate all old editor posts to new editor format - ensure we protect the code against mobiledoc or html field being null - ensure we create a blank mobiledoc structure if mobiledoc field is null (model layer) - ensure you can fully rollback 2.0 to 1.0 - keep mobiledoc/markdown version 1 logic to be able to rollback (deprecated code)
refs TryGhost#9601, refs TryGhost#9742 - Upgraded NQL to 0.1.0 - The new version of NQL supports aliases e.g. `tag: tags.slug`, which makes it possible to define `filter=tag:support` - Furthermore, this allows us to support advanced filtering like tag:[a,b] - In dynamic routing, we use mingo via NQL which has a slightly different feature set to GQL in the API: - AND NOT, OR and other advanced logic combos DO work on joined tables - Counts are not yet supported - The Dynamic Routing beta docs should describe that API filtering and Dynamic Routing filtering is different
no issue
refs TryGhost#9742 - removed usage of single permalink setting - with dynamic routing this configuration does no longer makes sense - because you can configure your permalinks in the routes.yaml - furthermore you can have multiple collections with multiple permalinks - removed @blog.permalinks - do not export permalink setting - do not import permalink setting - permalink setting UI will be removed soon - get rid of {globals.permalink} completely - remove yaml in-built migration - do not expose settings.permalinks via the private API - do not allow to edit this setting - keep phyiscal value in case a blog needs to rollback from v2 to v1 - sorted out when the routers should be created - ensure routes.yaml file doesn't get validated before Ghost is fully ready to start
refs TryGhost#9742 - removed demo post fixture for fresh blogs - added migration to remove the demo post from the database - on rollback: bring back demo post
no issue - GScan 2.0 is in progress - it's helpful to use a latest tarball already for testing
no issue - remove the special comment when migrating the routes.yaml file
…orters/data_spec.js no issue - added order option when fetching tags
closes TryGhost#9774, refs TryGhost#9742 - added new fixture posts for Ghost 2.0 - added migration file to remove old fixture posts - only remove them if they are owned by the Ghost author and if they are tagged with getting-started - added new fixture posts if you had all (!) old fixture posts - ensure on rollback we remove the new fixture posts again - updated default settings
… key refs TryGhost#9601 - when using the short form `data: tag.welcome` the redirect is enabled by default - /tag/welcome/ will redirect to the channel/collection which makes use of the data key - you can disable the redirect by using the long form e.g. data: tag: resource: tags type: read slug: welcome redirect: false
refs TryGhost#9601, refs TryGhost#9744 - the express router reference wasn't updated fully - the stack was the old router stack when you have uploaded a new routes.yaml file - this has caused e.g. that new redirects for channels/collections didn't work after the upload
no issue - optimised error message if you are trying to import a Ghost 0.X export - same applies to wordpress exports, i've raised in issue TryGhost/wp-ghost-exporter#12
no issue - we stringify the mobiledoc field and this ends in 'null' - the model layer won't detect 'null'
no issue - GScan 2.0 is in progress - it's helpful to use a latest tarball already for testing - https://github.com/TryGhost/gscan/commits/2.0
no issue - replace test themes - otherwise they are all invalid with the new GScan version - fix general tests because of Ghost 2.0 logic
no issue - IPC communication happens before we trigger process.exit - this is a timing issue - we should give IPC a little time to finish sending the message over to the CLI - wait 100ms before exiting the process
no issue - if you have a bootstrap socket configured, but the socket does not appear, Ghost would crash - cases: - your server bootstraps (Ghost-CLI automatically starts Ghost via systemd) - you add a bootstrap config in your Ghost config manually, but you don't start a net server - added handling to catch errors and retry 3 times
no issue
no issue
no issue - Organising your content From: Here, the theme would assign the post publicly displayed tags of Blog - but it would also keep a private record of the post being tagged with #video. To: Here, the theme would assign the post publicly displayed tags of News - but it would also keep a private record of the post being tagged with #video.
… data key name (TryGhost#9790) * 🐛 Dynamic Routing Beta: Shortform `author.foo` is not allowed refs TryGhost#9601 - otherwise you get access to {{author}} in the theme, which is deprecated & causes errors - recommend not using {{author}} as data longform name in the yaml validator - (internal usage is still allowed) - also warn against using reserved data key names like filter, resource, limit etc - maybe remove this restriction later but seems like a sensible validation right now.
no-issue The content api is for serving read-only content only. This route does not belong here.
no-issue The content API only supports GET requests so has no need for cors middleware on OPTIONS. This also removes the router.del helper as it's not used
…y part of fields filter (TryGhost#9969) closes TryGhost#9962 - Fixed the bug with url being set to /404 when id was not present on the model - Added a functional test to cover this bug - Refactored url decorating methods to be more clear about the nature of passed parameters
no-issue This ensures that slugs are stripped of illegal characters, and that we do not create duplicates.
no issue - since Ghost 2.0, the Ghost server takes care of executing `knex-migrator migrate` if needed
…st#10012) refs TryGhost#9866 - Refactored overrides config to include direct version configs(v0.1, v2), supported versions map to direct version - Refactored `getApiPath` to handle direct versions as well as mappings of supported version
no-issue This is to give serializers access to the expected data properties so that can be used for filtering.
refs TryGhost#9866 - Extracted url decoration logic to utility in output serializers in posts, pages, users, and tags - Added test cases for url usage by child object (tags of posts)
refs TryGhost#9866 - the logic in v2 was missing - it exists in v0.1
no issue - the permission service expects from the permissible function to respect the input values - hasUserPermissions - hasAppPermissions
no issue - just noticed that this test was sending the incorrect body data
no-issue
There are a few libraries, including node core that when given an array
for a query parameter will encode it as repeated query params. e.g.
```
{someParam: ['a', 'b']}
// becomes
'?someParam=a&someParam=b'
```
This adds a check for the value to stop us 500ing on repeated keys and
to add easier interop with http clients
* Extended webhooks schema/model and connected with integrations refs TryGhost#9942 - Updated webhooks schema with new columns - name, integration_id, secret, last_triggered_at, api_version - Updated webhooks and integration model to map relationships - Updated schema hash - Updated test utils to exclude new webhooks columns for response comparison * Added migration script for new webhooks columns refs TryGhost#9942 - Added migration script in 2.3 to add new columns to webhooks * Updated schema hash * Updated maxLength for api_version in schema * Removed concurrency value from migration script * Added defaults for webhooks model * Added status field to webhooks for last trigger status * Updated schema hash * Fixed tests with status field * Removed concurrency value in migration script * Cleanup * Updated schema with new fields - last_triggered_status, last_triggered_error
refs TryGhost#9865 - Made sessions table to be skipped during the export process
refs TryGhost#9866 - Switched update checker to api v2 - Updated and cleaned up the corresponding test suite - Updated the frame pipeline to respect context passed in with Frame instance - Exposed 'active' verison from api index module
no-issue - Added spam prevention to POST /session - This blocks repeated requests the the /session endpoint preventing brute force password attacks - Updated session controller to reset brute middleware - This updates the session controller to reset the brute force protection on a successful login. This is required so that a user is not locked out forever :o!!
…ryGhost#10031) closes TryGhost#10029 - allowed page option for users, posts, & tags browse - The page query param was not forwarding to the query, meaning that when the admin client requested the next page of users or posts, it would receive the first page again.
…10025) closes TryGhost#10024 - Updated input serializers for posts/tags/users to handle absolute urls conversion ------- 1. Ghost stores relative images urls 2. API V2 returns images with absolute urls 3. Ghost-Admin sends absolute urls back on any save e.g. update user **Current behavior**: This will override the relative image path in db to absolute, which in turn won't get updated in future if domain or protocol changes for e.g. **Fix**: On save/update, input serializers converts any absolute image url paths back to relative if the base URL from image fields matches the configured URL
Owner
Author
|
111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
npm test)More info can be found by clicking the "guidelines for contributing" link above.