Skip to content

Move to netcoreapp3.1 and make TestingAPIBackend.cs compilable #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seasoned-code wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move to netcoreapp3.1 and make TestingAPIBackend.cs compilable #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Matrix.Example.Client/Matrix.Example.Client.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.2</TargetFramework>
<TargetFramework>netcoreapp3.1</TargetFramework>
<LangVersion>7.2</LangVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
5 changes: 4 additions & 1 deletion Matrix.Tests/Backend/TestingAPIBackend.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@ namespace Matrix.Backends
{
public class TestingAPIBackend : IMatrixAPIBackend
{
public MatrixRequestError Get (string apiPath, bool authenticate, out JToken result) {
public MatrixRequestError Get (string apiPath, bool authenticate, out JToken result) {
result = null;
return null;
}

public Task<MatrixAPIResult> GetAsync(string apiPath, bool authenticate)
=> Task.FromResult<MatrixAPIResult>(default);

public MatrixRequestError Post (string apiPath, bool authenticate, JToken request, out JToken result) {
result = null;
return null;
Expand Down
2 changes: 1 addition & 1 deletion Matrix.Tests/Matrix.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp2.2</TargetFramework>
<TargetFramework>netcoreapp3.1</TargetFramework>
<LangVersion>7.2</LangVersion>
</PropertyGroup>
<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion Matrix/JSONEventConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public MatrixEventContent GetContent(JObject jobj,JsonSerializer serializer,stri
}
return content;
}
catch (Exception ex)
catch (Exception)
{
throw new Exception($"Failed to get content for {type}");
}
Expand Down