fix ReadWriteMultipleRegister support#6
Open
pieterg wants to merge 3 commits intoHakamFostok:masterfrom
Open
Conversation
so it can be overridden by classes which need to override ProtocolDataUnit
When using the base class MessageFrame implementation, it will call the base class ProtocolDataUnit, resulting in an invalid/incomplete message frame. By overriding MessageFrame, our overridden ProtocolDataUnit will be called instead.
ReadWriteMultipleRegisters response is the same as a ReadHoldingRegisters response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadWriteMultipleRegister support is not working, because the generated frame is incomplete.
The frame is created by ModbusMessageImpl.MessageFrame, which calls ModbusMessageImpl.ProtocolDataUnit internally, instead of the overridden ReadWriteMultipleRegisterRequest.ProtocolDataUnit.
By overriding ModbusMessageImpl.MessageFrame in ReadWriteMultipleRegisterRequest (duplicating the implementation, there might be a better solution), the generated ReadWriteMultipleRegister frame will be correct.
After fixing this, I found that the response is rejected, because ReadWriteMultipleRegisters was is not in the functionCode switch.
These commits result in working ReadWriteMultipleRegister support (tested with RTU)