-
Notifications
You must be signed in to change notification settings - Fork 0
Enable adding label without icon #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
50a4122
Allow adding label without icon
danleedham 3148b10
Linting
danleedham 27d26cb
Throw error if KMZ required and build called
danleedham b24616e
Update tests
danleedham 4404471
Update readme
danleedham badb7ae
Update PointStyleTests.swift
danleedham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| public enum KMZExportError: Error { | ||
| case kmzRequired | ||
| case missingLocalResource(String) | ||
| case archiveCreationFailed | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import Foundation | ||
| import ZIPFoundation | ||
|
|
||
| public extension ForeFlightKMLBuilder { | ||
|
|
||
| /// Build a KMZ (ZIP) containing doc.kml and any required local assets. | ||
| func buildKMZ() throws -> Data? { | ||
|
|
||
| let kmlData = kmlData() | ||
|
|
||
| let archive = try Archive(accessMode: .create) | ||
|
|
||
| try archive.addEntry( | ||
| with: "doc.kml", | ||
| type: .file, | ||
| uncompressedSize: Int64(kmlData.count), | ||
| compressionMethod: .deflate, | ||
| provider: { position, size in | ||
| let start = Int(position) | ||
| guard start < kmlData.count else { return Data() } | ||
| let end = min(start + size, kmlData.count) | ||
| return kmlData.subdata(in: start..<end) | ||
| } | ||
| ) | ||
|
|
||
| if requiresKMZ { | ||
| try addLocalAssets(to: archive) | ||
| } | ||
|
|
||
| return archive.data | ||
| } | ||
| } | ||
|
|
||
| private extension ForeFlightKMLBuilder { | ||
|
|
||
| func addLocalAssets(to archive: Archive) throws { | ||
|
|
||
| let bundle = Bundle.module | ||
|
|
||
| guard let iconURL = bundle.url(forResource: "1x1", withExtension: "png") else { | ||
| throw KMZExportError.missingLocalResource("1x1.png") | ||
| } | ||
|
|
||
| try archive.addEntry( | ||
| with: "1x1.png", | ||
| fileURL: iconURL, | ||
| compressionMethod: .deflate | ||
| ) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a pendantic point ref geometry naming. I think the thing we're calling a 'segment' should be called 'sector'.