Skip to content

Removed the redundant tooltip on hovering over a holiday#6261

Open
balajis-qb wants to merge 3 commits intoHacker0x01:mainfrom
qburst:issue-6260/holiday-tooltip
Open

Removed the redundant tooltip on hovering over a holiday#6261
balajis-qb wants to merge 3 commits intoHacker0x01:mainfrom
qburst:issue-6260/holiday-tooltip

Conversation

@balajis-qb
Copy link
Copy Markdown
Contributor

@balajis-qb balajis-qb commented Mar 17, 2026

Description

Linked issue: #6260

Problem
As I mentioned in the ticket, we're getting a redundant tooltip on hovering over a holiday. The reason is because we have added the same tooltip on the title and also added as a tooltip overlay. As a fix, I removed it from the holiday names from the title attribute.

Changes

  • Previously we're displaying both holidays and excluded date messages as a title. But I removed holiday messages from title as we're already displaying it as a custom tooltip overlay
  • Updated the test cases to check for holiday messages in the overlay instead of the title attribute.
  • Adjusted the position of the tooltip for a better UX.
  • Updated the example of the holiday dates to use dynamic year.

Screenshots

image

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

- Removed holiday from title.
- Retained holiday tooltip only in the hover tooltip.
- Updated tests to reflect changes in title to tooltip text for better clarity.

Closes Hacker0x01#6260
- Updated the bottom position of the overlay to ensure proper alignment.
…ar dynamically

- Changed the initialization of selectedDate to use the current date.
- Updated holiday dates to reflect the current year instead of hardcoded values.
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.31%. Comparing base (548a1f3) to head (bd7842a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6261      +/-   ##
==========================================
+ Coverage   99.29%   99.31%   +0.02%     
==========================================
  Files          30       30              
  Lines        3822     3818       -4     
  Branches     1648     1668      +20     
==========================================
- Hits         3795     3792       -3     
+ Misses         26       25       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant