♻️ Align Time Picker header styling with Date Picker header#6238
Open
balajis-qb wants to merge 1 commit intoHacker0x01:mainfrom
Open
♻️ Align Time Picker header styling with Date Picker header#6238balajis-qb wants to merge 1 commit intoHacker0x01:mainfrom
balajis-qb wants to merge 1 commit intoHacker0x01:mainfrom
Conversation
…les to match with DatePicker's header - Updated the time header in the DatePicker component from a div to an h2 element for better semantic structure. - Adjusted the SCSS styles to include the new h2 class for consistent styling. - Added a test to ensure the default time caption is rendered correctly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6238 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 30 30
Lines 3822 3822
Branches 1648 1665 +17
=======================================
Hits 3795 3795
Misses 26 26
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
As highlighted in the below image, there is a small mismatch between the DatePicker's header and TimePicker's header.
Code
Changes
divto anh2element for better semantic structure.Contribution checklist