-
Notifications
You must be signed in to change notification settings - Fork 9
hAlaa nahser w4 databases #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
hAlaa nahser w4 databases #39
Conversation
crevulus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, Alaa!
| @@ -0,0 +1,102 @@ | |||
| const { MongoClient, ServerApiVersion } = require("mongodb"); | |||
| const uri = | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be careful! Don't commit sensitive keys/codes etc to your remote repository. Hackers may be able to access them and steal your data.
Use an env file that you keep locally.
| const pipeline = [ | ||
| { | ||
| $match: { | ||
| Country: country, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to change this now - just bear this in mind!
Something you may want to consider when you're working with CSV data: Spreadsheets often use Title Case for their headings (Country, Year, etc.). When we're designing databses, we don't usually use this case. We usually use lowercase or snake_case, removing any whitespace and standardising the cases of the letters.
When converting from CSV to database columns you might want to consider your naming conventions. But you do not need to do that for this exercise - jsut something to remember for the future as not following naming conventions will make it harder/less intuitive for other people to work with your databases.
| }, | ||
| { | ||
| $group: { | ||
| _id: "$Year", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a data import file in your PR. Can you explain how you got your data into your db?
From the README:
Find a way to get the data in the csv file into your MongoDB database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imported the CSV file directly into MongoDB Atlas using the Atlas import tools. Was I supposed to handle the data import via Node.js instead?


No description provided.