-
Notifications
You must be signed in to change notification settings - Fork 9
Alaa_Nahser-w3-databases #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Alaa_Nahser-w3-databases #29
Conversation
Week3/homework/mongodb/index.js
Outdated
| .db("databaseWeek3") | ||
| .collection("bob_ross_episodes") | ||
| .updateMany({ elements: "BUSHES" }, [ | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your first argument to updateMany is fine, but your second argument is more complex than it needs to be. Can you find a way to simplify this? Try using the all-positional operator: https://www.mongodb.com/docs/manual/reference/operator/update/positional-all/
crevulus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alaa,
Your code is great! I've already approved, but I have left one comment. You might want to consider making your code simpler and leveraging existing utilities and functionality provided by the mongodb package.
crevulus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved PR by mistake (instead of just changing the label) - please do not merge the code.
|
I have edited the indes.js file. I used the all positional operator $[]. I hope it is good now. Thank you. |

No description provided.