Rizan_ibrahim-w4-database #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunchen4
requested changes
Jun 14, 2025
yunchen4
left a comment
yunchen4
left a comment
There was a problem hiding this comment.
Hi Rizan,
There are two points you need to rework, and I have made them explicit. Please let me know on Slack after you finish the rework!
Comment on lines
+36
to
+45
| const result = await collection | ||
| .aggregate([ | ||
| { $match: { Year: year, Age: age } }, | ||
| { | ||
| $addFields: { | ||
| TotalPopulation: { $add: ["$M", "$F"] }, | ||
| }, | ||
| }, | ||
| ]) | ||
| .toArray(); |
There was a problem hiding this comment.
Needs rework: In the CSV file you can see continents are mixed with countries, for example there are documents for AFRICA. In this case you cannot just add all documents.
But I have to say it is not a good dataset 😅
Comment on lines
9
to
65
| export async function transfer(fromAcc, toAcc, amount, remark) { | ||
| try { | ||
| await client.connect(); | ||
| const db = client.db(dbName); | ||
| const accounts = db.collection("accounts"); | ||
|
|
||
| // Fetch both accounts | ||
| const sender = await accounts.findOne({ account_number: fromAcc }); | ||
| const receiver = await accounts.findOne({ account_number: toAcc }); | ||
|
|
||
| if (!sender || !receiver) { | ||
| throw new Error("One or both accounts not found."); | ||
| } | ||
|
|
||
| if (sender.balance < amount) { | ||
| throw new Error("Insufficient funds."); | ||
| } | ||
|
|
||
| const nextSenderChange = sender.account_changes.length + 1; | ||
| const nextReceiverChange = receiver.account_changes.length + 1; | ||
|
|
||
| await accounts.updateOne( | ||
| { account_number: fromAcc }, | ||
| { | ||
| $inc: { balance: -amount }, | ||
| $push: { | ||
| account_changes: { | ||
| change_number: nextSenderChange, | ||
| amount: -amount, | ||
| changed_date: new Date(), | ||
| remark: `Sent to ${toAcc}: ${remark}`, | ||
| }, | ||
| }, | ||
| } | ||
| ); | ||
|
|
||
| await accounts.updateOne( | ||
| { account_number: toAcc }, | ||
| { | ||
| $inc: { balance: amount }, | ||
| $push: { | ||
| account_changes: { | ||
| change_number: nextReceiverChange, | ||
| amount: amount, | ||
| changed_date: new Date(), | ||
| remark: `Received from ${fromAcc}: ${remark}`, | ||
| }, | ||
| }, | ||
| } | ||
| ); | ||
|
|
||
| console.log(`Transfer of ${amount} from ${fromAcc} to ${toAcc} completed.`); | ||
| } catch (err) { | ||
| console.error("Transfer failed:", err.message); | ||
| } finally { | ||
| await client.close(); | ||
| } |
There was a problem hiding this comment.
Needs rework: I didn't see you're using transactions here?
yunchen4
reviewed
Jun 20, 2025
Comment on lines
+12
to
+19
| const continents = [ | ||
| "AFRICA", | ||
| "ASIA", | ||
| "EUROPE", | ||
| "LATIN AMERICA AND THE CARIBBEAN", | ||
| "NORTHERN AMERICA", | ||
| "OCEANIA", | ||
| ]; |
There was a problem hiding this comment.
Good to filter them out 😄 It solves the problem from the origin.
yunchen4
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.