Hussam-W1-database #8
Conversation
yunchen4
left a comment
yunchen4
left a comment
There was a problem hiding this comment.
Hi Hussam,
I didn't see your code for exercise 1. Could you please upload it and let me know on Slack when it is available? Thank you!
Week1/databases/meetup/world.js
Outdated
| const selectCountriesOfContinent=`SELECT name FROM country WHERE continent='Europe';`; | ||
| const res3=await client.query(selectCountriesOfContinent); | ||
| console.log(res3.rows); | ||
| const selectCountriesOrderBysurfaceArea=`SELECT * DROM country ORDER BY surfacearea DESC;`; |
There was a problem hiding this comment.
Needs rework: syntax error for SELECT * DROM country ORDER BY surfacearea DESC;
Week1/databases/meetup/world.js
Outdated
| const selectcitiesNamesOfCountry=`SELECT name FROM city WHERE CountryCode='NLD';`; | ||
| const res5=await client.query(selectcitiesNamesOfCountry); | ||
| console.log(res5.rows); | ||
| const selectPopulationOfCity=`SELECT Population FROM city WHERE Name='Roterdam';`; |
There was a problem hiding this comment.
Another misspelling for city name SELECT Population FROM city WHERE Name='Roterdam';
Week1/databases/meetup/index.js
Outdated
| const createInviteeTableQuery=`CREATE TABLE IF NOT EXISTS invitee( | ||
| invitee_no SERIAL PRIMARY KEY, | ||
| invitee_name VARCHAR(255) NOT NULL, | ||
| INVITEE_BY VARCHAR(255) NOT NULL);`; |
There was a problem hiding this comment.
Suggestion: better to keep the column names in the same case (preferably lower case).
Week1/databases/meetup/index.js
Outdated
| const creatRoomTableQuery=`CREATE TABLE IF NOT EXISTS room( | ||
| room_no SERIAL PRIMARY KEY, | ||
| room_name VARCHAR(255) NOT NULL, | ||
| floor_number INT NOT NULL);`; |
There was a problem hiding this comment.
Suggestion: usually the floor number is not a big number. Depending on the floor range, you can use type SMALLINT. This way you can reduce the size of table.
You can check the range for the number types: https://www.postgresql.org/docs/current/datatype-numeric.html
2 participants
No description provided.