Hussam-w4-database #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunchen4
requested changes
Sep 19, 2025
yunchen4
left a comment
yunchen4
left a comment
There was a problem hiding this comment.
Hi Hussam,
The assignment is very good. Only a small point that needs rework.
Please let me know once you finish the rework. Have a nice weekend!
Comment on lines
21
to
30
| async function getInformationOfPopulation(client, year, age) { | ||
| const res = await client | ||
| .db(dbName) | ||
| .collection("population") | ||
| .aggregate([ | ||
| { $addFields: { totalPopulation: { $add: ["$M", "$F"] } } }, | ||
| { $match: { Age: age, Year: year } }, | ||
| ]); | ||
| return res.toArray(); | ||
| } |
There was a problem hiding this comment.
Needs rework: The exercise asks about the total population per continent. Please find out how to aggregate this info in the provided data. But I have to say the data provided in this exercise is not very good, as it mixes the continent and countries.
Comment on lines
+28
to
+33
| if (!fromAcc || !toAcc) { | ||
| throw new Error("Account not found"); | ||
| } | ||
| if (fromAcc.balance < amount) { | ||
| throw new Error(`Insufficient funds in account ${fromAccount}`); | ||
| } |
There was a problem hiding this comment.
Very good that you check whether the accounts exist and the balance beforehand.
yunchen4
requested changes
Sep 28, 2025
Comment on lines
29
to
32
| $group: { | ||
| _id: "$Continent", | ||
| totalPopulation: { $sum: "$totalPopulation" }, | ||
| }, |
There was a problem hiding this comment.
Needs rework: Did I miss anything? I didn't see there is a Continent field in the sample data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.