Yaroslav kazeev w4 databases #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunchen4
requested changes
Sep 19, 2025
yunchen4
left a comment
yunchen4
left a comment
There was a problem hiding this comment.
Hi Yaroslav,
The assignment looks good to me! Only a small point that needs rework.
Please let me know once you finish rework. Thanks!
Comment on lines
25
to
32
| await account.updateOne( | ||
| { account_number: receiver_account_number }, | ||
| { $inc: { balance: amount } }, | ||
| { | ||
| $push: { account_changes: { amount: amount, changed_date, remark } }, | ||
| }, | ||
| { session } | ||
| ); |
There was a problem hiding this comment.
Needs rework: the position of $push is wrong for the second updateOne.
Comment on lines
+35
to
+36
| } catch (error) { | ||
| console.log("Transaction aborted.", error); |
There was a problem hiding this comment.
suggestion: It's ok in the assignment to use simple error handling (just logging). In real working situation, usually the error will be thrown or return some thing that clearly differentiates the normal state without error.
Author
|
Thanks for your suggestions, Chen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.