Igor w3 databases #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunchen4
requested changes
Sep 19, 2025
Comment on lines
+1
to
+11
| function getPopulation(Country, name, code, cb) { | ||
| conn.query( | ||
| "SELECT Population FROM ?? WHERE Name = ? AND code = ?", | ||
| [Country, name, code], | ||
| function (err, result) { | ||
| if (err) return cb(err); | ||
| if (result.length === 0) return cb(new Error("Not found")); | ||
| cb(null, result[0].Population); | ||
| } | ||
| ); | ||
| } |
There was a problem hiding this comment.
Needs rework: I didn't see the answer to question 1 in exercise 3?
Comment on lines
+9
to
+14
| // Deduct from account 101 | ||
| await conn.execute(`UPDATE account SET balance = balance - 1000 WHERE account_number = 101`); | ||
| await conn.execute( | ||
| `INSERT INTO account_changes (account_number, amount, remark) VALUES (?, ?, ?)`, | ||
| [101, -1000, "Transfer to 102"] | ||
| ); |
There was a problem hiding this comment.
Suggestion: no need to change your implementation for transactions, but it is better to check whether the accounts exist and whether the balance is enough before doing actual transactions.
| * It seems an errand episode has gotten into our data. | ||
| * This is episode 14 in season 31. Please remove it and verify that it has been removed! | ||
| */ | ||
| const bobRossCollection = client.db("databaseWeek3").collection("bob_ross_episodes"); |
There was a problem hiding this comment.
Suggestion: you may notice this line appears multiple times in this file. In this case, you can extract it into another function. You can also have two string constants for "databaseWeek3" and "bob_ross_episodes", so you can reuse those strings and avoid typos in future. And in future if you want to change database name, you don't need to change them one by one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.