Hussam-w3-database #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunchen4
approved these changes
Sep 19, 2025
yunchen4
left a comment
yunchen4
left a comment
There was a problem hiding this comment.
LGTM, only some suggestions for code maintainability
Comment on lines
+7
to
+9
| if(res.rows[0].balance<=1000){ | ||
| throw new Error('Insufficient funds in account 101'); | ||
| } |
There was a problem hiding this comment.
Nice check of balance beforehand. You can also check whether the accounts exist.
| * It seems an errand episode has gotten into our data. | ||
| * This is episode 14 in season 31. Please remove it and verify that it has been removed! | ||
| */ | ||
| const deleteResult=await client.db('DatabaseWeek3').collection('bob_ross_episodes').deleteOne({episode:'S31E14'}) |
There was a problem hiding this comment.
Suggestion: you may notice client.db('DatabaseWeek3').collection('bob_ross_episodes') appears multiple times in this file. In this case, you can extract it into another function. You can also have two string constants for "databaseWeek3" and "bob_ross_episodes", so you can reuse those strings and avoid typos in future. And in future if you want to change database name, you don't need to change them one by one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.