Open
Conversation
sycons
approved these changes
Feb 15, 2026
sycons
left a comment
sycons
left a comment
There was a problem hiding this comment.
Well done! You seem to have a good grasp on algorithms and using them in problem solving ⭐
- Count values above a threshold ✅
- Write Unit Tests ✅
- Debug and Fix the Logic ✅
- Algorithm performance experiment ✅
There was a problem hiding this comment.
Minor change: Naming convention for test files usually follows the file it is testing. In this case that would be calculateAverage.test.js.
| console.log(countVowels("hello")); | ||
| console.log(countVowels("javascript")); | ||
| console.log(countVowels("JLOOIKANJDK")); | ||
| console.log(countVowels("EIOAEYoiibtd")); |
There was a problem hiding this comment.
Another possible test case is an empty text.
|
|
||
| function linear_search(array, target) { | ||
| for (let i = 0; i< array.length; i++){ | ||
| if(array[i] === target) { |
There was a problem hiding this comment.
Pay attention to code formatting. Indented code is easier to read.
sycons
added
the
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.