Open
Conversation
sycons
requested changes
Feb 15, 2026
sycons
left a comment
sycons
left a comment
There was a problem hiding this comment.
You have a good grasp on algorithms and using them in problem solving. However pay attention to the test cases (missing for upper case) and also calling the search functions on all the arrays and for different target values.
- Count values above a threshold ✅
- Write Unit Tests ✅
- Debug and Fix the Logic ✅
|
|
||
| console.log(countVowels("hello")); | ||
| console.log(countVowels("javascript")); | ||
| console.log(countVowels("")); |
There was a problem hiding this comment.
A test case for uppercase vowels would be good here.
|
|
||
| const arr1 = generateBigArray(1000); | ||
| const arr2 = generateBigArray(100000); | ||
| const arr3 = generateBigArray(10000000); |
There was a problem hiding this comment.
More descriptive names might be better. E.g. bigArray10M
|
|
||
| console.time("linearSearch arr3"); | ||
| console.log(linearSearch(arr3, 123456789)); | ||
| console.timeEnd("linearSearch arr3"); |
There was a problem hiding this comment.
Execution of search for the other arrays are missing as well as additional target values other than 123456789
sycons
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.