Open
Conversation
mo92othman
approved these changes
Feb 15, 2026
mo92othman
left a comment
mo92othman
left a comment
There was a problem hiding this comment.
Hey @Miuroro ,
Good job on this week’s assignment! You show a solid understanding of the core concepts! very good work 👏
| @@ -1 +1,23 @@ | |||
| //Your code here | |||
There was a problem hiding this comment.
You can delete these kinds of unnecessary instruction lines.
Comment on lines
+4
to
+5
| for (let i = 0; i < text.length; i++) { | ||
| // using i <= text.length makes text[i] become undefined |
There was a problem hiding this comment.
Good debugging work. You fixed the loop condition!
Comment on lines
+26
to
+30
| - Should uppercase vowels be counted? | ||
| yes, to make the function more user-friendly | ||
| we can convert the text to lowercase before counting the vowels. | ||
| This way, both uppercase and lowercase vowels will be counted. | ||
| */ |
There was a problem hiding this comment.
Good thinking, however, the function still does not count uppercase vowels because the conversion to lowercase was not implemented.
mo92othman
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.