Skip to content

Diana C.#1

Open
dianadenwik wants to merge 1 commit intoHackYourAssignment:mainfrom
dianadenwik:main
Open

Diana C.#1
dianadenwik wants to merge 1 commit intoHackYourAssignment:mainfrom
dianadenwik:main

Conversation

@dianadenwik
Copy link

No description provided.

@sycons sycons self-assigned this Feb 8, 2026
Copy link

@sycons sycons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following were implemented:

  • Setup & configure project ✅
  • Create a transactions array ✅
  • Implement required functions ✅
  • Implement display requirements ✅
  • Display summary report ✅
  • Code quality ✅

Well done! Your code is clear in it's implementation and you've used javascript well (appropriate loops, object destructuring) ⭐

I've provided some feedback to improve the structure of your app. This is usually how apps are strucutured i.e. functions and the calls to them are in different files.

@@ -1,27 +1,132 @@
import { transactions } from './data.js';

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra lines between import statements. Not a deal breaker, but preferred way to format files.


import chalk from 'chalk';

console.log(chalk.bold('💰 PERSONAL FINANCE TRACKER 💰'));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move these lines to app.js. This file is the entry point and statements that should be executed like console.log() and your functions should be called in app.js.

This file finance.js should have only your functions.

@sycons sycons added Reviewed This assignment has been reivewed by a mentor and a feedback has been provided and removed To review labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed This assignment has been reivewed by a mentor and a feedback has been provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants